| Summary: | REGRESSION: Search highlight is broken in RTL multicolumn content | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
| Component: | Layout and Rendering | Assignee: | Andrei Bucur <abucur> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abucur, commit-queue, esprehn+autocc, glenn, hyatt, koivisto, kondapallykalyan, mihnea, simon.fraser | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
The problem here is that RenderMultiColumnFlowThread::mapFromFlowToRegion doesn't add the layer offset when computing the translation offset despite the fact RenderMultiColumnSet::columnTranslationForOffset returns an offset from the layer's top left corner. This is in contract to RenderLayer::collectFragments. It calls RenderMultiColumnSet::collectLayerFragments, which also returns an offset from the layer's top left corner, but it adds the layer offset so everything is fine there. I found the issue and I have a fix. Working on the patch ATM. Created attachment 235829 [details]
Patch
Comment on attachment 235829 [details] Patch Clearing flags on attachment: 235829 Committed r171882: <http://trac.webkit.org/changeset/171882> All reviewed patches have been landed. Closing bug. *** Bug 135453 has been marked as a duplicate of this bug. *** |
Created attachment 235808 [details] test case Reproduction steps: 1. Open the attached file in the nightly build of WebKit 2. Find "hello" via Cmd+F. Expected result: "hello" is highlighted Actual result: The yellow highlight shows up on the left of "hello".