Bug 135451

Summary:

PropertyName's internal string is always atomic.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

JavaScriptCore

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	benjamin: review+

Description Andreas Kling 2014-07-30 21:25:18 PDT

We should exploit this more.

Comment 1 Andreas Kling 2014-07-30 21:28:39 PDT

Created attachment 235805 [details]
Patch

Comment 2 Benjamin Poulain 2014-07-30 22:34:39 PDT

Comment on attachment 235805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235805&action=review

> Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:57
> -    AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName);
> +    AtomicStringImpl* atomicPropertyName = propertyName.publicName();
>      return atomicPropertyName && document->hasDocumentNamedItem(*atomicPropertyName);

Looks like another of those cases where we query a hash table multiple times to access a property from JavaScript :(

Comment 3 Andreas Kling 2014-07-30 22:38:54 PDT

Committed r171838: <http://trac.webkit.org/changeset/171838>