Bug 135451

Summary: PropertyName's internal string is always atomic.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Andreas Kling
Reported 2014-07-30 21:25:18 PDT
We should exploit this more.
Attachments
Patch (10.85 KB, patch)
2014-07-30 21:28 PDT, Andreas Kling 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-07-30 21:28:39 PDT
Created attachment 235805 [details] Patch
Benjamin Poulain
Comment 2 2014-07-30 22:34:39 PDT
Comment on attachment 235805 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235805&action=review > Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:57 > - AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName); > + AtomicStringImpl* atomicPropertyName = propertyName.publicName(); > return atomicPropertyName && document->hasDocumentNamedItem(*atomicPropertyName); Looks like another of those cases where we query a hash table multiple times to access a property from JavaScript :(
Andreas Kling
Comment 3 2014-07-30 22:38:54 PDT
Committed r171838: <http://trac.webkit.org/changeset/171838>
Note You need to log in before you can comment on or make changes to this bug.