Summary: | REGRESSION (r21120): Member profile frame not erased at Yahoo! Answers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | Keywords: | HasReduction, Regression | ||||||
Priority: | P1 | ||||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
URL: | http://answers.yahoo.com/question/index;_ylt=AlI3YLa80K83KWiexkufjz3py6IX?qid=20070429145338AA5bJni | ||||||||
Attachments: |
|
Description
mitz
2007-04-29 15:16:58 PDT
Created attachment 14271 [details]
Reduction
Layers need to repaint when turning invisible.
Created attachment 14272 [details]
Repaint layers becoming invisible even if they also need layout
Includes change log and repaint test.
Random unrelated question, but why did your previous change remove a setNeedsLayout(false) call? Was it redundant? Comment on attachment 14272 [details]
Repaint layers becoming invisible even if they also need layout
r=me
(In reply to comment #3) > Random unrelated question, but why did your previous change remove a > setNeedsLayout(false) call? Was it redundant? > layoutBlockChildren uses the logic that "we don't need to repaint children if the parent needs layout, because in that case it will do a full repaint". But by resetting the bit in layoutBlockChildren it was invalidating this logic since by the time layoutBlock called repaintAfterLayoutIfNeeded, the latter couldn't tell that it needed to do a full repaint. I think I explained it in my ChangeLog ;-) and it's covered by one of the repaint tests IIRC. Reading ChangeLogs is hard. |