REGRESSION (r21120): Member profile frame not erased at Yahoo! Answers

• Component: Layout and Rendering
• Status: RESOLVED FIXED

Repaint regression, probably introduced in <http://trac.webkit.org/projects/webkit/changeset/21120>: open the URL and hover over a member's avatar and wait for the member info box to appear, then move the mouse away to make the box disappear. Three sides of the gray frame remain visible until you force a repaint.

Created attachment 14271 [details]
Reduction

Layers need to repaint when turning invisible.

Created attachment 14272 [details]
Repaint layers becoming invisible even if they also need layout

Includes change log and repaint test.

[Dave Hyatt]

Random unrelated question, but why did your previous change remove a setNeedsLayout(false) call?  Was it redundant?

[Dave Hyatt]

Comment on attachment 14272 [details]
Repaint layers becoming invisible even if they also need layout

r=me

[Mark Rowe (bdash)]

Landed in r21186.

(In reply to comment #3)
> Random unrelated question, but why did your previous change remove a
> setNeedsLayout(false) call?  Was it redundant?
> 

layoutBlockChildren uses the logic that "we don't need to repaint children if the parent needs layout, because in that case it will do a full repaint". But by resetting the bit in layoutBlockChildren it was invalidating this logic since by the time layoutBlock called repaintAfterLayoutIfNeeded, the latter couldn't tell that it needed to do a full repaint. I think I explained it in my ChangeLog ;-) and it's covered by one of the repaint tests IIRC.

[Dave Hyatt]

Reading ChangeLogs is hard.