Bug 135432 – Web Inspector: console.profile missing profile information

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

* SUMMARY
Switching console.profile to use the Timelines instead of the older ProfilerAgent, we have to remember to tell JSC to recompile functions as soon as WebCore has changed the "supportsProfiling" status. Previously the profiler was always on when the inspector is open. We should go back to that.

* STEPS TO REPRODUCE
1. Inspect http://www.webkit.org/misc/drosera/
2. Click "Nested functions" which does a console.profile
3. View JavaScript & Events timeline in inspector
  => should show "rot" function, but currently does not

[Joseph Pecoraro]

Created attachment 235771 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 235771 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=235771&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.h:285
> +    int m_recordingProfileDepth;

ptrdiff_t! :)

Or size_t and just assert that m_recordingProfileDepth > 0 before --m_recordingProfileDepth.

[Radar WebKit Bug Importer]

<rdar://problem/17872082>

[WebKit Commit Bot]

Comment on attachment 235771 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 235771

Committed r171866: <http://trac.webkit.org/changeset/171866>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.