Bug 135414

Summary: Build warning in webkit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
Product: WebKit Reporter: Tanay <tanay.c>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mhahnenberg, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Tanay 2014-07-30 02:47:31 PDT 
Build warning as follows
/home/tanay.c/webkit-tar/webkit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1447:18: warning: unused parameter ‘vm’ [-Wunused-parameter]
 static JSObject* putToScopeCommon(ExecState* exec, Instruction* pc, VM& vm)
Comment 1 Tanay 2014-07-30 02:59:04 PDT 
Created attachment 235738 [details]
Patch
Comment 2 Mark Hahnenberg 2014-07-30 05:53:59 PDT 
Comment on attachment 235738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235738&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1447
> +static JSObject* putToScopeCommon(ExecState* exec, Instruction* pc, VM& /*vm*/)

You don't need to comment it out. Since it's not adding any useful information, you can simply remove the parameter name entirely.
Comment 3 Tanay 2014-07-30 22:26:28 PDT 
Created attachment 235807 [details]
Patch
Comment 4 WebKit Commit Bot 2014-07-31 10:38:03 PDT 
Comment on attachment 235807 [details]
Patch

Clearing flags on attachment: 235807

Committed r171867: <http://trac.webkit.org/changeset/171867>
Comment 5 WebKit Commit Bot 2014-07-31 10:38:05 PDT 
All reviewed patches have been landed.  Closing bug.