Bug 135413

Summary: Clean up the WebKit build from unused parameter warning in Webkit2/WebProcess module
Product: WebKit Reporter: Rohit <kumar.rohit>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, gyuyoung.kim, rniwa, ryuan.choi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rohit
Reported 2014-07-30 01:50:53 PDT
Clean up WebKit build from usused parameters since r171749. [ 82%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/__/__/DerivedSources/WebKit2/CoordinatedLayerTreeHostProxyMessageReceiver.cpp.o /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:57:6: warning: unused parameter ‘types’ [-Wunused-parameter] void WebOriginDataManager::getOrigins(WKOriginDataTypes types, uint64_t callbackID) ^ /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:73:6: warning: unused parameter ‘types’ [-Wunused-parameter] void WebOriginDataManager::deleteEntriesForOrigin(WKOriginDataTypes types, const SecurityOriginData& originData, uint64_t callbackID) ^ /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:73:6: warning: unused parameter ‘originData’ [-Wunused-parameter] /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:88:6: warning: unused parameter ‘types’ [-Wunused-parameter] void WebOriginDataManager::deleteEntriesModifiedBetweenDates(WKOriginDataTypes types, double startTime, double endTime, uint64_t callbackID) ^ /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:88:6: warning: unused parameter ‘startTime’ [-Wunused-parameter] /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:88:6: warning: unused parameter ‘endTime’ [-Wunused-parameter] /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:102:6: warning: unused parameter ‘types’ [-Wunused-parameter] void WebOriginDataManager::deleteAllEntries(WKOriginDataTypes types, uint64_t callbackID) ^ Linking CXX shared library ../../lib/libewebkit2.so
Attachments
Patch (2.72 KB, patch)
2014-07-30 02:03 PDT, Rohit 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rohit
Comment 1 2014-07-30 02:03:41 PDT
Created attachment 235737 [details] Patch
WebKit Commit Bot
Comment 2 2014-07-31 10:15:28 PDT
Comment on attachment 235737 [details] Patch Clearing flags on attachment: 235737 Committed r171861: <http://trac.webkit.org/changeset/171861>
WebKit Commit Bot
Comment 3 2014-07-31 10:15:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.