Bug 135407

Summary: [EFL] Do not initialize g_type system explicitly in the ewk_init()
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jinwoo Song
Reported 2014-07-29 21:05:33 PDT
EFL build requires glib version 2.38 but g_type_init() has been deprecated since version 2.36. As the type system is initialized automatically since version 2.36, we do not need to call g_type_init() in the ewk_init(). https://developer.gnome.org/gobject/unstable/gobject-Type-Information.html#g-type-init
Attachments
Patch (1.59 KB, patch)
2014-07-29 21:08 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-07-29 21:08:50 PDT
Created attachment 235731 [details] Patch
Gyuyoung Kim
Comment 2 2014-07-29 21:10:48 PDT
Comment on attachment 235731 [details] Patch LGTM
WebKit Commit Bot
Comment 3 2014-07-29 21:26:30 PDT
Comment on attachment 235731 [details] Patch Clearing flags on attachment: 235731 Committed r171788: <http://trac.webkit.org/changeset/171788>
WebKit Commit Bot
Comment 4 2014-07-29 21:26:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.