Summary: | Web Inspector: 80% of time during recording is spent creating source code locations for profile nodes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-07-29 15:43:16 PDT
Created attachment 235732 [details]
[PATCH] Proposed Fix
I attempted to merge LazySourceCodeLocation into SourceCodeLocation, but I wasn't see-ing the same performance wins as this patch, so I decided to go back to this. Ultimately I think it would make sense to fold this into SourceCodeLocation if it is possible. For now, I think this is a good compromise.
Comment on attachment 235732 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=235732&action=review > Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:281 > + _initializeProfileFromPayload: function(payload) As much as I hate leaking protocol data past the controllers into the model, I this this is fine for the perf win. Comment on attachment 235732 [details] [PATCH] Proposed Fix Clearing flags on attachment: 235732 Committed r171790: <http://trac.webkit.org/changeset/171790> All reviewed patches have been landed. Closing bug. (In reply to comment #3) > (From update of attachment 235732 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235732&action=review > > > Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:281 > > + _initializeProfileFromPayload: function(payload) > > As much as I hate leaking protocol data past the controllers into the model, I this this is fine for the perf win. The profileFromPayload could go anywhere (it could go in TimelineManager). It is a standalone factory like method. |