| Summary: | CSS animations @keyframes / @-webkit-keyframes appear to crash Safari 8.0 on OS X Yosemite Public Beta | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | sichunlam | ||||
| Component: | Animations | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Major | CC: | benjamin, bjonesbe, commit-queue, darin, dino, kling, panda3330, sichunlam, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac (Intel) | ||||||
| OS: | OS X 10.9 | ||||||
| URL: | http://www.sichunlam.com/projects/webkit-test/ | ||||||
| Attachments: |
|
||||||
|
Description
sichunlam
2014-07-29 14:56:16 PDT
Created attachment 235725 [details]
Patch
Comment on attachment 235725 [details] Patch Clearing flags on attachment: 235725 Committed r171785: <http://trac.webkit.org/changeset/171785> All reviewed patches have been landed. Closing bug. Comment on attachment 235725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235725&action=review > Source/WebCore/ChangeLog:12 > + To keep this fix minimal, simply make the "parent style" a clone of the > + base element style. What would be the non-minimal fix approach? (In reply to comment #5) > (From update of attachment 235725 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235725&action=review > > > Source/WebCore/ChangeLog:12 > > + To keep this fix minimal, simply make the "parent style" a clone of the > > + base element style. > > What would be the non-minimal fix approach? I'd imagine we could come up with a way to avoid cloning the RenderStyle here just to serve as a placeholder for the parent style. (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 235725 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=235725&action=review > > > > > Source/WebCore/ChangeLog:12 > > > + To keep this fix minimal, simply make the "parent style" a clone of the > > > + base element style. > > > > What would be the non-minimal fix approach? > > I'd imagine we could come up with a way to avoid cloning the RenderStyle here just to serve as a placeholder for the parent style. Don't we need an actual parent style to get correct computation of the font-size em value? Or is there something special about animations I'm missing? |