| Summary: | [TexMap] Move TextureMapperLayer::textureMapper() definition into the header | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, kondapallykalyan, luiz, mrobinson, noam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2014-07-29 06:46:57 PDT
Created attachment 235685 [details]
Patch
Comment on attachment 235685 [details]
Patch
Does this result in notable performance improvement. I ask because changes like these also increase code size.
Inlining the two methods results in the generation of 7 instructions in total that crawl up the combined chain of effect targets and parent layers. I think this is a better alternative to the overhead of branching into a separate function and setting up the prologue and epilogue there. This only affects three call sites, one of which was noticeably hot during the profiling. It's still only a small improvement, but comes at a minimal cost of increase in code size. Comment on attachment 235685 [details] Patch Clearing flags on attachment: 235685 Committed r171795: <http://trac.webkit.org/changeset/171795> All reviewed patches have been landed. Closing bug. |