| Summary: | Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Hodovan <mhodovan.u-szeged> | ||||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, darin, jchaffraix, kling, ossy, rniwa, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Martin Hodovan
2014-07-29 01:49:23 PDT
Created attachment 235671 [details] Proposed patch Patch by Timothy Loh, backported from Blink: https://codereview.chromium.org/71253002 Comment on attachment 235671 [details] Proposed patch Attachment 235671 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6253934939209728 New failing tests: storage/indexeddb/intversion-revert-on-abort.html Created attachment 235691 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
> storage/indexeddb/intversion-revert-on-abort.html
This test was flaky yesterday; the offending patch has already been rolled out.
Comment on attachment 235671 [details] Proposed patch Rejecting attachment 235671 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 235671, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5254335390810112 Created attachment 235826 [details]
Patch for landing
Comment on attachment 235826 [details] Patch for landing Clearing flags on attachment: 235826 Committed r171871: <http://trac.webkit.org/changeset/171871> All reviewed patches have been landed. Closing bug. |