Summary: | Canvex example starts rendering strangely after a while | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Elliott Sprehn <esprehn> | ||||
Component: | Layout and Rendering | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, gavin.sharp | ||||
Priority: | P2 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
URL: | http://canvex.lazyilluminati.com/83/play.xhtml | ||||||
Attachments: |
|
Description
Elliott Sprehn
2007-04-29 01:13:53 PDT
Reproducible in the latest nightly (Sun Apr 29 3:44:55 GMT 2007). I've debugged this and determined that the problem is that Safari's canvas will throw an exception if drawImage arguments are no good. That's what the WhatWG specification says we should do <http://www.whatwg.org/specs/web-apps/current-work/#images>, but here in the Canvex example it's causing us to do a save() without a restore() and the clip is getting stuck. Created attachment 14347 [details]
patch; tolerate 0 sizes without raising an exception
Comment on attachment 14347 [details]
patch; tolerate 0 sizes without raising an exception
r=me
Sending LayoutTests/ChangeLog Deleting LayoutTests/fast/canvas/drawImage-with-invalid-args-expected.checksum Deleting LayoutTests/fast/canvas/drawImage-with-invalid-args-expected.png Sending LayoutTests/fast/canvas/drawImage-with-invalid-args-expected.txt Sending LayoutTests/fast/canvas/drawImage-with-invalid-args.html Sending WebCore/ChangeLog Sending WebCore/html/CanvasRenderingContext2D.cpp Transmitting file data ..... Committed revision 21280. |