Bug 135360

Summary: Web Inspector: Unexpected dark border on selected but window inactive timeline
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Issue
none
Patch
none
Patch none

Joseph Pecoraro
Reported 2014-07-28 15:39:17 PDT
* SUMMARY Unexpected dark border on selected but window inactive timeline. * STEPS TO REPRODUCE 1. Inspect apple.com 2. Click Timelines 3. Click Layout & Rendering 4. Click desktop to blur the window => unexpected dark border under "Layout & Rendering"
Attachments
[IMAGE] Issue (13.75 KB, image/png)
2014-07-28 15:51 PDT, Joseph Pecoraro 		no flags
Details
Patch (2.37 KB, patch)
2014-07-28 16:57 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (2.52 KB, patch)
2014-07-28 17:20 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-07-28 15:40:44 PDT
<rdar://problem/17835401>
Joseph Pecoraro
Comment 2 2014-07-28 15:51:36 PDT
Created attachment 235624 [details] [IMAGE] Issue Image of the issue.
Timothy Hatcher
Comment 3 2014-07-28 16:47:57 PDT
I have a fix.
Timothy Hatcher
Comment 4 2014-07-28 16:57:33 PDT
Created attachment 235643 [details] Patch
Joseph Pecoraro
Comment 5 2014-07-28 17:05:05 PDT
Comment on attachment 235643 [details] Patch This still looks a little weird to me. Compare when Network is selected and the window is inactive to when Layout & Rendering is selected and the window is inactive. In the Layout & Rendering case, the selected row has no top border but a bottom border. Could be expected, but still looks a little uneven. Leaving cq to you.
Timothy Hatcher
Comment 6 2014-07-28 17:20:51 PDT
Created attachment 235650 [details] Patch
Joseph Pecoraro
Comment 7 2014-07-28 17:24:55 PDT
Comment on attachment 235650 [details] Patch r=me Much nicer! Thanks
WebKit Commit Bot
Comment 8 2014-07-28 17:58:34 PDT
Comment on attachment 235650 [details] Patch Clearing flags on attachment: 235650 Committed r171716: <http://trac.webkit.org/changeset/171716>
WebKit Commit Bot
Comment 9 2014-07-28 17:58:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.