Bug 135360

Summary: Web Inspector: Unexpected dark border on selected but window inactive timeline
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Issue
none
Patch
none
Patch none

Description Joseph Pecoraro 2014-07-28 15:39:17 PDT 
* SUMMARY
Unexpected dark border on selected but window inactive timeline.

* STEPS TO REPRODUCE
1. Inspect apple.com
2. Click Timelines
3. Click Layout & Rendering
4. Click desktop to blur the window
  => unexpected dark border under "Layout & Rendering"
Comment 1 Radar WebKit Bug Importer 2014-07-28 15:40:44 PDT 
<rdar://problem/17835401>
Comment 2 Joseph Pecoraro 2014-07-28 15:51:36 PDT 
Created attachment 235624 [details]
[IMAGE] Issue

Image of the issue.
Comment 3 Timothy Hatcher 2014-07-28 16:47:57 PDT 
I have a fix.
Comment 4 Timothy Hatcher 2014-07-28 16:57:33 PDT 
Created attachment 235643 [details]
Patch
Comment 5 Joseph Pecoraro 2014-07-28 17:05:05 PDT 
Comment on attachment 235643 [details]
Patch

This still looks a little weird to me.

Compare when Network is selected and the window is inactive to when Layout & Rendering is selected and the window is inactive. In the Layout & Rendering case, the selected row has no top border but a bottom border. Could be expected, but still looks a little uneven.

Leaving cq to you.
Comment 6 Timothy Hatcher 2014-07-28 17:20:51 PDT 
Created attachment 235650 [details]
Patch
Comment 7 Joseph Pecoraro 2014-07-28 17:24:55 PDT 
Comment on attachment 235650 [details]
Patch

r=me

Much nicer! Thanks
Comment 8 WebKit Commit Bot 2014-07-28 17:58:34 PDT 
Comment on attachment 235650 [details]
Patch

Clearing flags on attachment: 235650

Committed r171716: <http://trac.webkit.org/changeset/171716>
Comment 9 WebKit Commit Bot 2014-07-28 17:58:36 PDT 
All reviewed patches have been landed.  Closing bug.