| Summary: | Use WTF::move() instead of std::move() to help ensure move semantics | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
| Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, benjamin, berto, cgarcia, cmarcelo, commit-queue, gustavo, mrobinson, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Bates
2014-07-28 13:58:46 PDT
Created attachment 235615 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Attachment 235615 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/GetByIdVariant.cpp:42: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 235615 [details] Patch Clearing flags on attachment: 235615 Committed r171746: <http://trac.webkit.org/changeset/171746> All reviewed patches have been landed. Closing bug. |