| Summary: | Web Replay: auto-decoding of parameterized vector's elements is incorrect | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||
| Component: | WebCore Misc. | Assignee: | Brian Burg <burg> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, joepeck, kling, timothy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Brian Burg
2014-07-28 11:14:10 PDT
Created attachment 235599 [details]
Patch
Comment on attachment 235599 [details]
Patch
wrong patch. i hate you, webkit-patch
Created attachment 235602 [details]
Patch
Comment on attachment 235602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235602&action=review > Source/JavaScriptCore/replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.cpp:61 > +SavedHistory::~SavedHistory() > +{ > +} > } // namespace Test A newline before the namespace close would be nice. > Source/JavaScriptCore/replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.h:91 > +}; > } // namespace Test Ditto. Comment on attachment 235602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235602&action=review >> Source/JavaScriptCore/replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.cpp:61 >> } // namespace Test > > A newline before the namespace close would be nice. right now it uses tight namespace spacing on both sides. It could be changed, but since there are many explicit namespaces i opted for the more condensed style. Comment on attachment 235602 [details] Patch Clearing flags on attachment: 235602 Committed r171684: <http://trac.webkit.org/changeset/171684> All reviewed patches have been landed. Closing bug. |