Bug 135325

Summary:

[WebKit2 iOS]Add support for caret movement for the 3rd party keyboard protocol

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit2

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Enrica Casucci

Reported 2014-07-26 19:40:19 PDT

We need to implement a way to move the caret in one forward/backward by n positions. <rdar://problem/17682120>

Attachments
Patch (6.85 KB, patch) 2014-07-26 19:44 PDT, Enrica Casucci	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Enrica Casucci

Comment 1 2014-07-26 19:44:14 PDT

Created attachment 235579 [details] Patch

WebKit Commit Bot

Comment 2 2014-07-26 19:45:31 PDT

Attachment 235579 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:421: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:534: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Enrica Casucci

Comment 3 2014-07-27 10:25:53 PDT

Committed revision 171651.

Note You need to log in before you can comment on or make changes to this bug.