Summary: | Web Inspector: Timelines performance is very slow, has many forced layouts | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, erik.bryn+bugzilla, graouts, joepeck, jonowells, simon.fraser, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-07-25 18:58:30 PDT
Created attachment 235555 [details]
[PATCH] Proposed Fix
This is meant to reduce the number of obviously unnecessary forced layouts.
I think there is still work to be done to improve the performance even more during a recording, but I think this is big step forward both during a recording and post-recording when using the timelines.
Comment on attachment 235555 [details]
[PATCH] Proposed Fix
Awesome!
Comment on attachment 235555 [details]
[PATCH] Proposed Fix
Ugh, some typos in the ChangeLog I want to fix before landing. Will wait for review.
Created attachment 235560 [details]
[PATCH] Proposed Fix
Better. It turns out showEmptyPlaceholder could also benefit from the early return if nothing changed. This is another huge win if the time range selection doesn't start at 0.0. Otherwise we would have hit the same forced layout loop calling this over and over. Note, the messages is always the same so maybe we can simplify this a bit more.
Comment on attachment 235560 [details] [PATCH] Proposed Fix Clearing flags on attachment: 235560 Committed r171645: <http://trac.webkit.org/changeset/171645> All reviewed patches have been landed. Closing bug. *** Bug 131651 has been marked as a duplicate of this bug. *** |