Bug 135313

Summary:

Web Inspector: Timelines performance is very slow, has many forced layouts

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, erik.bryn+bugzilla, graouts, joepeck, jonowells, simon.fraser, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2014-07-25 18:58:30 PDT

* SUMMARY Working with the Timelines panel there are a lot of performance issues. There are many forced layouts, multi-second hangs, and it can be unresponsive to user actions. * STEPS TO REPRODUCE - 1 1. Inspect apple.com 2. Start a timeline recording 3. Focus the search field in the top right of the page 4. Type "test string" => everything is slow during the recording 5. Stop recording 6. Select the Script or Layout timeline => hangs for a very long time

Attachments
[PATCH] Proposed Fix (8.39 KB, patch) 2014-07-25 19:04 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (8.88 KB, patch) 2014-07-25 20:08 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-07-25 18:59:04 PDT

<rdar://problem/17818693>

Joseph Pecoraro

Comment 2 2014-07-25 19:04:08 PDT

Created attachment 235555 [details] [PATCH] Proposed Fix This is meant to reduce the number of obviously unnecessary forced layouts. I think there is still work to be done to improve the performance even more during a recording, but I think this is big step forward both during a recording and post-recording when using the timelines.

Simon Fraser (smfr)

Comment 3 2014-07-25 19:18:45 PDT

Comment on attachment 235555 [details] [PATCH] Proposed Fix Awesome!

Joseph Pecoraro

Comment 4 2014-07-25 19:22:56 PDT

Comment on attachment 235555 [details] [PATCH] Proposed Fix Ugh, some typos in the ChangeLog I want to fix before landing. Will wait for review.

Joseph Pecoraro

Comment 5 2014-07-25 20:08:10 PDT

Created attachment 235560 [details] [PATCH] Proposed Fix Better. It turns out showEmptyPlaceholder could also benefit from the early return if nothing changed. This is another huge win if the time range selection doesn't start at 0.0. Otherwise we would have hit the same forced layout loop calling this over and over. Note, the messages is always the same so maybe we can simplify this a bit more.

WebKit Commit Bot

Comment 6 2014-07-26 09:43:16 PDT

Comment on attachment 235560 [details] [PATCH] Proposed Fix Clearing flags on attachment: 235560 Committed r171645: <http://trac.webkit.org/changeset/171645>

WebKit Commit Bot

Comment 7 2014-07-26 09:43:19 PDT

All reviewed patches have been landed. Closing bug.

Joseph Pecoraro

Comment 8 2014-07-30 12:36:39 PDT

*** Bug 131651 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.