| Summary: | Fix 32-bit build breakage for type profiling | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, mhahnenberg | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Saam Barati
2014-07-25 11:56:54 PDT
Created attachment 235538 [details]
patch
32-bit builds currently break because global variable IDs for high fidelity type profiling are int64_t. Change this to intptr_t so that it's 32 bits on 32-bit platforms and 64 bits on 64-bit platforms.
Comment on attachment 235538 [details]
patch
r=me
Comment on attachment 235538 [details] patch Rejecting attachment 235538 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 235538, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: |+++ Source/JavaScriptCore/runtime/TypeLocationCache.h (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored patching file Source/JavaScriptCore/runtime/VM.h Hunk #1 FAILED at 521. Hunk #2 FAILED at 573. 2 out of 2 hunks FAILED -- saving rejects to file Source/JavaScriptCore/runtime/VM.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Mark Hahnenberg']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5589563628060672 Oops, commit queue only knows about trunk. Landed manually in http://trac.webkit.org/changeset/171611 |