Summary: | REGRESSION(r171526): [SOUP] Massive crashes. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | WebKitGTK | Assignee: | Pratik Solanki <psolanki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Blocker | CC: | berto, cgarcia, mrobinson, ossy, psolanki, rego, simon.fraser, yoon, zan | ||||||
Priority: | P1 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 135069 | ||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2014-07-24 20:46:08 PDT
Uh oh.. Looking. Created attachment 235495 [details]
GDB Backtrace for the GTK port when running the perft test Animation/balls.html
I have attached a GDB backtrace for the coredump generated when running the perf test Animation/balls.html Relevant part: Program terminated with signal 11, Segmentation fault. #0 0x00007f9c955a6f36 in WebCore::SharedBuffer::append(char const*, unsigned int) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25 [...] Thread 1 (Thread 0x7f9c87619940 (LWP 6612)): #0 0x00007f9c955a6f36 in WebCore::SharedBuffer::append(char const*, unsigned int) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25 #1 0x00007f9c95aec465 in WebCore::SharedBuffer::maybeTransferPlatformData() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25 #2 0x00007f9c955a6f2b in WebCore::SharedBuffer::append(char const*, unsigned int) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25 #3 0x00007f9c955a7f11 in WebCore::SharedBuffer::append(WebCore::SharedBuffer*) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25 #4 0x00007f9c95461ac1 in WebCore::ResourceLoader::addDataOrBuffer(char const*, unsigned int, WebCore::SharedBuffer*, WebCore::DataPayloadType) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25 [...] (In reply to comment #0) > > All the GTK test bots started to crash for *every* layout test / performance test after this revision. > After a more detailed look it seems that causes crashes for many layout test, but not for every layout test. It seems however to cause crashes for every performance test. Created attachment 235496 [details]
Patch
I have tested the attached patch. It fixes the issue. Thanks a lot :) Since this is build breakage, I'll just land it unreviewed. Carlos has confirmed that it fixes the crashes. Committed r171579: <http://trac.webkit.org/changeset/171579> (In reply to comment #8) > Committed r171579: <http://trac.webkit.org/changeset/171579> It fixed the issue on EFL too since EFL also uses SOUP. |