Bug 135283 – REGRESSION(r171526): [SOUP] Massive crashes.

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

Revision r171526 <http://trac.webkit.org/r171526> seems to have caused *massive* crashes on the GTK port.

All the GTK test bots started to crash for *every* layout test / performance test after this revision.

Last good build for the GTK Release test boot (r171525): http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/1678
First bad build for the GTK Release test boot (r171526): http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/1679 [Exiting early after 47 crashes and 3 timeouts.]

And the same for the perf bot or the GTK Debug test boot :\

[Pratik Solanki]

Uh oh.. Looking.

[Carlos Alberto Lopez Perez]

Created attachment 235495 [details]
GDB Backtrace for the GTK port when running the perft test Animation/balls.html

[Carlos Alberto Lopez Perez]

I have attached a GDB backtrace for the coredump generated when running the perf test Animation/balls.html 

Relevant part:

Program terminated with signal 11, Segmentation fault.
#0  0x00007f9c955a6f36 in WebCore::SharedBuffer::append(char const*, unsigned int) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25

[...]


Thread 1 (Thread 0x7f9c87619940 (LWP 6612)):
#0  0x00007f9c955a6f36 in WebCore::SharedBuffer::append(char const*, unsigned int) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25
#1  0x00007f9c95aec465 in WebCore::SharedBuffer::maybeTransferPlatformData() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25
#2  0x00007f9c955a6f2b in WebCore::SharedBuffer::append(char const*, unsigned int) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25
#3  0x00007f9c955a7f11 in WebCore::SharedBuffer::append(WebCore::SharedBuffer*) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25
#4  0x00007f9c95461ac1 in WebCore::ResourceLoader::addDataOrBuffer(char const*, unsigned int, WebCore::SharedBuffer*, WebCore::DataPayloadType) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-3.0.so.25
[...]

[Carlos Alberto Lopez Perez]

(In reply to comment #0)
> 
> All the GTK test bots started to crash for *every* layout test / performance test after this revision.
> 

After a more detailed look it seems that causes crashes for many layout test, but not for every layout test.

It seems however to cause crashes for every performance test.

[Pratik Solanki]

Created attachment 235496 [details]
Patch

[Carlos Alberto Lopez Perez]

I have tested the attached patch. It fixes the issue. Thanks a lot :)

[Pratik Solanki]

Since this is build breakage, I'll just land it unreviewed. Carlos has confirmed that it fixes the crashes.

[Pratik Solanki]

Committed r171579: <http://trac.webkit.org/changeset/171579>

[Csaba Osztrogonác]

(In reply to comment #8)
> Committed r171579: <http://trac.webkit.org/changeset/171579>

It fixed the issue on EFL too since EFL also uses SOUP.