Bug 135278

Summary:

REGRESSION(r164401): Placing a caret doesn't bring up autocorrection panel

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ddavidso, enrica

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	thorton: review+

Description Ryosuke Niwa 2014-07-24 18:50:04 PDT

REGRESSION(r164401): Placing a caret doesn't bring up autocorrection panel

Comment 1 Ryosuke Niwa 2014-07-24 18:55:54 PDT

Created attachment 235488 [details]
Fixes the bug

Comment 2 Ryosuke Niwa 2014-07-24 18:56:29 PDT

<rdar://problem/17748416>

Comment 3 Tim Horton 2014-07-24 20:08:01 PDT

Comment on attachment 235488 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=235488&action=review

> Source/WebCore/ChangeLog:9
> +        triggred by ditaction instead of only if it was NOT triggred by dictation.

sp.: triggered

> Source/WebCore/ChangeLog:13
> +        options around but the boolean logic was erroneously.

erroneously what? maybe just "erroneous"

Comment 4 Ryosuke Niwa 2014-07-24 21:51:31 PDT

Committed r171580: <http://trac.webkit.org/changeset/171580>