Bug 135277

Summary: [iOS][WK2] Do not try to hit test a null mainFrameRenderView on dynamicViewportSizeUpdate()
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Benjamin Poulain 2014-07-24 18:44:47 PDT
[iOS][WK2] Do not try to hit test a null mainFrameRenderView on dynamicViewportSizeUpdate()
Comment 1 Benjamin Poulain 2014-07-24 18:52:14 PDT
Created attachment 235487 [details]
Patch
Comment 2 Tim Horton 2014-07-24 18:55:29 PDT
Comment on attachment 235487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235487&action=review

> Source/WebKit2/ChangeLog:11
> +        There is no guarantee that the main frame have its root layer when performing a dynamicViewportSizeUpdate(),

s/have/has/

should "layer" be "view"?

> Source/WebKit2/ChangeLog:18
> +        When the hit test is not done, the position restored become a relative in the content size.

the end of this sentence is grammatically wrong but I'm not sure the best way to fix it and it's not important :D
Comment 3 Benjamin Poulain 2014-07-24 20:01:29 PDT
Committed r171576: <http://trac.webkit.org/changeset/171576>