Bug 135276

Summary: Rename MAC_LONG_PRESS feature flag to LONG_MOUSE_PRESS.
Product: WebKit Reporter: Peyton Randolph <prandolph>
Component: UI EventsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, commit-queue, prandolph, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Other   
Bug Depends on:    
Bug Blocks: 135257, 135476    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
none
LONG_MOUSE_PRESS
none
Patch
none
Patch none

Peyton Randolph
Reported 2014-07-24 18:35:18 PDT
I'd like to rename the MAC_LONG_PRESS feature flag to LONG_PRESS as other platforms may want a long-press gesture.
Attachments
Patch (30.74 KB, patch)
2014-07-24 18:44 PDT, Peyton Randolph 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (534.85 KB, application/zip)
2014-07-24 21:54 PDT, Build Bot 		no flags
Details
LONG_MOUSE_PRESS (30.33 KB, patch)
2014-07-25 15:57 PDT, Peyton Randolph 		no flags
DetailsFormatted DiffDiff
Patch (31.18 KB, patch)
2014-08-05 11:49 PDT, Peyton Randolph 		no flags
DetailsFormatted DiffDiff
Patch (30.85 KB, patch)
2014-08-05 12:14 PDT, Peyton Randolph 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Peyton Randolph
Comment 1 2014-07-24 18:44:54 PDT
Created attachment 235486 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-07-24 18:53:24 PDT
I think we decided on LONG_MOUSE_PRESS.
Build Bot
Comment 3 2014-07-24 21:53:58 PDT
Comment on attachment 235486 [details] Patch Attachment 235486 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5277886441324544 New failing tests: media/track/add-and-remove-track.html
Build Bot
Comment 4 2014-07-24 21:54:01 PDT
Created attachment 235499 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Peyton Randolph
Comment 5 2014-07-25 15:57:57 PDT
Created attachment 235548 [details] LONG_MOUSE_PRESS
Peyton Randolph
Comment 6 2014-08-05 11:49:23 PDT
Created attachment 236041 [details] Patch
WebKit Commit Bot
Comment 7 2014-08-05 12:03:06 PDT
Comment on attachment 236041 [details] Patch Rejecting attachment 236041 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 236041, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog is not at the top of the file. Full output: http://webkit-queues.appspot.com/results/5422742669099008
Peyton Randolph
Comment 8 2014-08-05 12:14:13 PDT
Created attachment 236042 [details] Patch
WebKit Commit Bot
Comment 9 2014-08-05 12:53:24 PDT
Comment on attachment 236042 [details] Patch Clearing flags on attachment: 236042 Committed r172048: <http://trac.webkit.org/changeset/172048>
WebKit Commit Bot
Comment 10 2014-08-05 12:53:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.