Bug 135270

Summary: ImageDiff builds for the simulator when running iOS layout tests
Product: WebKit Reporter: David Farler <dfarler>
Component: Tools / TestsAssignee: David Farler <dfarler>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, ddkilzer, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: All   
Attachments:
Description Flags
Patch simon.fraser: review+

Description David Farler 2014-07-24 16:46:04 PDT
ImageDiff is a host-side tool for comparing image output from layout tests and should only ever run on the host. As it stands, there is no good way to do separate aggregate target members to build against a different SDK in Xcode, so we can provide a tool, build-imagediff, which run-webkit-tests can invoke if necessary and --no-build wasn't passed.
Comment 1 David Farler 2014-07-24 17:23:51 PDT
Created attachment 235479 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-07-24 17:32:05 PDT
Comment on attachment 235479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235479&action=review

> Tools/ChangeLog:3
> +        ImageDiff builds for the simulator when running iOS layout tests

I think this should say "Build ImageDiff for the simulator"?
Comment 3 David Farler 2014-07-24 18:32:09 PDT
(In reply to comment #2)
> (From update of attachment 235479 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235479&action=review
> 
> > Tools/ChangeLog:3
> > +        ImageDiff builds for the simulator when running iOS layout tests
> 
> I think this should say "Build ImageDiff for the simulator"?

Nope, it already builds for the simulator. The script it a shortcut to build it for the host at all times. Running it in the sim bootstrap is pretty slow and not really necessary. webkitpy will invoke it out of WebKitBuild/Debug.
Comment 4 David Farler 2014-07-28 13:00:00 PDT
Committed r171686: <http://trac.webkit.org/changeset/171686>