Bug 135240

Summary:

ResourceErrorBase::compare doesn’t call the right platformCompare override

Product:

WebKit

Reporter:

mitz

Component:

Platform

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, beidson, berto, cdumez, cgarcia, commit-queue, danw, gustavo, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Call ResourceError::platformCompare	none
Call ResourceError::platformCompare	ap: review+

Description mitz 2014-07-24 10:01:25 PDT

ResourceErrorBase::compare calls platformCompare. It should call the ResourceError::platformCompare override.

Comment 1 mitz 2014-07-24 21:59:12 PDT

Created attachment 235500 [details]
Call ResourceError::platformCompare

Comment 2 mitz 2014-07-24 22:37:52 PDT

Created attachment 235503 [details]
Call ResourceError::platformCompare

Comment 3 Alexey Proskuryakov 2014-07-24 22:50:00 PDT

Comment on attachment 235503 [details]
Call ResourceError::platformCompare

Do we ever compare errors? What does that even mean? Looking at these methods, I want to delete them, not to fix them.

Comment 4 mitz 2014-07-24 22:55:56 PDT

(In reply to comment #3)
> (From update of attachment 235503 [details])
> Do we ever compare errors?

I don’t see anywhere in WebCore that we do.

> What does that even mean?

Checking whether two errors are the same ;-)

> Looking at these methods, I want to delete them, not to fix them.

Yeah, I’d rather do that if possible.

Comment 5 mitz 2014-07-25 09:42:08 PDT

operator!= turned out to be used in comparing authentication challenges.

Fixed in <http://trac.webkti.org/r171600>.