| Summary: | [TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, kondapallykalyan, luiz, mrobinson, noam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2014-07-24 05:38:34 PDT
Created attachment 235426 [details]
Patch
Comment on attachment 235426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235426&action=review > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:84 > - virtual bool addAnimation(const KeyframeValueList&, const IntSize&, const Animation*, const String&, double); > + virtual bool addAnimation(const KeyframeValueList&, const FloatSize&, const Animation*, const String&, double); I think adding override to this delcaration is a good idea, since it has the potential to catch these errors in the future. Comment on attachment 235426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235426&action=review >> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:84 >> + virtual bool addAnimation(const KeyframeValueList&, const FloatSize&, const Animation*, const String&, double); > > I think adding override to this delcaration is a good idea, since it has the potential to catch these errors in the future. That should be done throughout the texmap code. I'll at least run clang-modernize over it, but there are also other things I want to improve. Comment on attachment 235426 [details] Patch Clearing flags on attachment: 235426 Committed r171725: <http://trac.webkit.org/changeset/171725> All reviewed patches have been landed. Closing bug. |