Bug 135237

Summary: [TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, kondapallykalyan, luiz, mrobinson, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2014-07-24 05:38:34 PDT
[TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize
Attachments
Patch (2.65 KB, patch)
2014-07-24 05:43 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-07-24 05:43:13 PDT
Created attachment 235426 [details] Patch
Martin Robinson
Comment 2 2014-07-24 07:20:00 PDT
Comment on attachment 235426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235426&action=review > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:84 > - virtual bool addAnimation(const KeyframeValueList&, const IntSize&, const Animation*, const String&, double); > + virtual bool addAnimation(const KeyframeValueList&, const FloatSize&, const Animation*, const String&, double); I think adding override to this delcaration is a good idea, since it has the potential to catch these errors in the future.
Zan Dobersek
Comment 3 2014-07-29 01:10:06 PDT
Comment on attachment 235426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235426&action=review >> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:84 >> + virtual bool addAnimation(const KeyframeValueList&, const FloatSize&, const Animation*, const String&, double); > > I think adding override to this delcaration is a good idea, since it has the potential to catch these errors in the future. That should be done throughout the texmap code. I'll at least run clang-modernize over it, but there are also other things I want to improve.
Zan Dobersek
Comment 4 2014-07-29 01:13:31 PDT
Comment on attachment 235426 [details] Patch Clearing flags on attachment: 235426 Committed r171725: <http://trac.webkit.org/changeset/171725>
Zan Dobersek
Comment 5 2014-07-29 01:13:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.