Bug 135229

Summary: [Cocoa] WebCore::ProtectionSpace doesn’t preserve all NSURLProtectionSpace properties, such as the distinguishedNames array
Product: WebKit Reporter: mitz
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, ap, buildbot, bunhere, commit-queue, gyuyoung.kim, rakuco, rniwa, sam, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP for EWS
none
WIP for EWS
none
WIP for EWS
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
none
WIP for EWS
none
WIP for EWS
none
WIP for EWS
none
WIP for EWS
none
Make ProtectionSpace hold onto an NSURLProtectionSpace; encode/decode it if necessary ap: review+

Description mitz 2014-07-23 23:59:30 PDT 
<rdar://problem/17766348>

A WebCore::ProtectionSpace isn’t a faithful representation of the NSURLProtectionSpace it’s created from. In particular, this means that the distinguishedNames property, used to match client identities to an authentication challenge, is lost when the challenge is sent from the Networking process to the UI process.
Comment 1 mitz 2014-07-24 00:02:29 PDT 
Created attachment 235408 [details]
WIP for EWS
Comment 2 WebKit Commit Bot 2014-07-24 00:04:27 PDT 
Attachment 235408 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:57:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:74:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:81:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:79:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:81:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:101:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:102:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:102:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:103:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:39:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:45:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61:  Wrong number of spaces before statement. (expected: 53)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:32:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:40:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:41:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:42:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:43:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:179:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 29 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2014-07-24 00:35:44 PDT 
Created attachment 235409 [details]
WIP for EWS
Comment 4 WebKit Commit Bot 2014-07-24 00:37:28 PDT 
Attachment 235409 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:57:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:74:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:81:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:39:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:45:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:79:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:81:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:101:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:102:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:102:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:103:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61:  Wrong number of spaces before statement. (expected: 53)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:32:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:40:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:41:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:42:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:43:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:179:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 29 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 mitz 2014-07-24 00:58:13 PDT 
Created attachment 235410 [details]
WIP for EWS
Comment 6 WebKit Commit Bot 2014-07-24 01:00:48 PDT 
Attachment 235410 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:57:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:74:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:81:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:39:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:45:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:79:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:81:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:101:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:102:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:102:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:103:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61:  Wrong number of spaces before statement. (expected: 53)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:61:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:32:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:40:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:41:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:42:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:43:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:179:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 29 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Build Bot 2014-07-24 05:18:33 PDT 
Comment on attachment 235410 [details]
WIP for EWS

Attachment 235410 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5812128833339392

New failing tests:
http/tests/xmlhttprequest/basic-auth-default.html
http/tests/security/credentials-in-referer.html
http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url.html
http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
http/tests/security/401-logout/401-logout.php
http/tests/xmlhttprequest/re-login-async.html
http/tests/loading/basic-credentials-sent-automatically.html
http/tests/misc/401-alternative-content.php
http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html
http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html
http/tests/xmlhttprequest/basic-auth-nouser.html
http/tests/xmlhttprequest/failed-auth.html
http/tests/xmlhttprequest/remember-bad-password.html
http/tests/loading/basic-auth-resend-wrong-credentials.html
http/tests/xmlhttprequest/basic-auth.html
Comment 8 Build Bot 2014-07-24 05:18:40 PDT 
Created attachment 235425 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 mitz 2014-07-24 10:33:44 PDT 
Created attachment 235434 [details]
WIP for EWS
Comment 10 mitz 2014-07-24 10:43:57 PDT 
Created attachment 235435 [details]
WIP for EWS
Comment 11 WebKit Commit Bot 2014-07-24 10:46:24 PDT 
Attachment 235435 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:55:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:74:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:81:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:79:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:81:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:97:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:98:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:98:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:99:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:35:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:41:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:47:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:56:  Wrong number of spaces before statement. (expected: 53)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:56:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:172:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 mitz 2014-07-24 11:25:40 PDT 
Created attachment 235437 [details]
WIP for EWS
Comment 13 WebKit Commit Bot 2014-07-24 11:28:42 PDT 
Attachment 235437 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:55:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:74:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:81:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:79:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:81:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:97:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:98:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:98:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:99:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:35:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:41:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:47:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:56:  Wrong number of spaces before statement. (expected: 53)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:56:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:172:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 mitz 2014-07-24 12:01:59 PDT 
Created attachment 235440 [details]
WIP for EWS
Comment 15 WebKit Commit Bot 2014-07-24 12:03:42 PDT 
Attachment 235440 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:55:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:74:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:81:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:79:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:81:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:97:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:98:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:98:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:99:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:35:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:41:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:47:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:56:  Wrong number of spaces before statement. (expected: 53)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:56:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:172:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 mitz 2014-07-24 13:10:46 PDT 
Created attachment 235450 [details]
Make ProtectionSpace hold onto an NSURLProtectionSpace; encode/decode it if necessary
Comment 17 WebKit Commit Bot 2014-07-24 13:13:03 PDT 
Attachment 235450 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:42:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:48:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:55:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:57:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:74:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.h:81:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:79:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:80:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:81:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:97:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:98:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:98:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/ProtectionSpaceBase.cpp:99:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:35:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:41:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:41:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/ProtectionSpace.h:47:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:56:  Wrong number of spaces before statement. (expected: 53)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/AuthenticationCF.cpp:56:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/mac/AuthenticationMac.mm:172:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.mm:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:310:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 33 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 18 Alexey Proskuryakov 2014-07-24 14:53:26 PDT 
Comment on attachment 235450 [details]
Make ProtectionSpace hold onto an NSURLProtectionSpace; encode/decode it if necessary

View in context: https://bugs.webkit.org/attachment.cgi?id=235450&action=review

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:1
> -<?xml version="1.0" encoding="utf-8"?>
> +<?xml version="1.0" encoding="utf-8"?>

:-/

> Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:29
> +#include "ProtectionSpaceBase.h"

Please add an #if/#error somewhere here to indicate that this is a Windows only file.

> Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:58
> +    bool encodingRequiresPlatformData() const { return m_nsSpace && !encodingRequiresPlatformData(m_nsSpace.get()); }

!
Comment 19 Alexey Proskuryakov 2014-08-05 15:11:12 PDT 
Dan landed this in <http://trac.webkit.org/changeset/171540> (with a few build fixes afterwards).