| Summary: | Web Inspector: add eject current recording button to the replay dashboard | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED LATER | ||||||||
| Severity: | Normal | CC: | graouts, inspector-bugzilla-changes, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | 135170, 135212 | ||||||||
| Bug Blocks: | 136292 | ||||||||
| Attachments: |
|
||||||||
|
Description
Brian Burg
2014-07-23 18:24:43 PDT
Created attachment 235401 [details]
Patch
I am not sure the dashboard is the right place for this. I would expect to see if in the control navigation bar in the Timeline sidebar. Though I suppose it can be in both places, like the Debugger dashboard has resume. Is eject a common enough action to put into the dashboard that you need to do it while looking at other views/sidebars? Created attachment 236417 [details]
Patch
(In reply to comment #4) > Though I suppose it can be in both places, like the Debugger dashboard has resume. Is eject a common enough action to put into the dashboard that you need to do it while looking at other views/sidebars? Eject is a common action, because it unlocks user input and other controls on determinism. So if you had been interacting with a captured execution, ejecting the current session will allow new user inputs, navigations, timers, etc to be processed. I do think that it also belongs in the timelines sidebar panel navigation bar. Those buttons need to be updated: currently they do not listen for replay events (paused, ejected, etc) so they don't always match the dashboard buttons. The important parts of this patch are the additions to the protocol and manager that implement an "eject" operation. The buttons are a way to test this until replay recordings and timeline recordings are better integrated in the UI. Comment on attachment 236417 [details]
Patch
This is rebaselined and follows new conventions for promise-based APIs.
Maybe eject and the icon are not the best terms. Maybe a mouse icon or something like that would be better? Maybe it could be crossed out or locked when replaying. As a user I wouldn't think eject meant I could interact with the page again. I would almost think unload the page and go to about:blank. Closing web replay-related bugs until we resume working on the feature again. |