Summary: | [iOS WK2] Header bar on nytimes articles lands in the wrong place after rubberbanding | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, sergio, simon.fraser, thorton | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 135223 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2014-07-23 17:02:05 PDT
Created attachment 235392 [details]
Patch
Comment on attachment 235392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235392&action=review > Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:219 > +#if PLATFORM(IOS) > + m_webPageProxy->didCommitLayerTree(layerTreeTransaction); > +#endif > + Uh, isn't that gonna bring all the scrolling bugs back? I think that's where the code was. Re-opened since this is blocked by bug 135223 Comment on attachment 235392 [details] Patch Attachment 235392 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6390063927656448 New failing tests: media/track/add-and-remove-track.html Created attachment 235398 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 235473 [details]
Patch
Comment on attachment 235473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235473&action=review > Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:181 > + if (scrolledNodeID == rootScrollingNodeID() && m_requestedScrollInfo) { > + m_requestedScrollInfo->requestsScrollPositionUpdate = true; > + m_requestedScrollInfo->requestIsProgrammaticScroll = representsProgrammaticScroll; > + m_requestedScrollInfo->requestedScrollPosition = scrollPosition; > + } ouch, that's not pretty. |