Bug 135221

Summary: [iOS WK2] Header bar on nytimes articles lands in the wrong place after rubberbanding
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, sergio, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 135223    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
none
Patch benjamin: review+

Description Simon Fraser (smfr) 2014-07-23 17:02:05 PDT
Header bar on nytimes articles lands in the wrong place after rubberbanding
Comment 1 Simon Fraser (smfr) 2014-07-23 17:06:20 PDT
Created attachment 235392 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-07-23 17:06:59 PDT
<rdar://problem/17542454>
Comment 3 Simon Fraser (smfr) 2014-07-23 17:23:49 PDT
https://trac.webkit.org/r171498
Comment 4 Benjamin Poulain 2014-07-23 18:00:43 PDT
Comment on attachment 235392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235392&action=review

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:219
> +#if PLATFORM(IOS)
> +    m_webPageProxy->didCommitLayerTree(layerTreeTransaction);
> +#endif
> +

Uh, isn't that gonna bring all the scrolling bugs back? I think that's where the code was.
Comment 5 WebKit Commit Bot 2014-07-23 18:10:00 PDT
Re-opened since this is blocked by bug 135223
Comment 6 Build Bot 2014-07-23 18:12:37 PDT
Comment on attachment 235392 [details]
Patch

Attachment 235392 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6390063927656448

New failing tests:
media/track/add-and-remove-track.html
Comment 7 Build Bot 2014-07-23 18:12:41 PDT
Created attachment 235398 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Simon Fraser (smfr) 2014-07-24 16:52:21 PDT
Created attachment 235473 [details]
Patch
Comment 9 Benjamin Poulain 2014-07-24 17:10:58 PDT
Comment on attachment 235473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235473&action=review

> Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:181
> +    if (scrolledNodeID == rootScrollingNodeID() && m_requestedScrollInfo) {
> +        m_requestedScrollInfo->requestsScrollPositionUpdate = true;
> +        m_requestedScrollInfo->requestIsProgrammaticScroll = representsProgrammaticScroll;
> +        m_requestedScrollInfo->requestedScrollPosition = scrollPosition;
> +    }

ouch, that's not pretty.
Comment 10 Simon Fraser (smfr) 2014-07-24 17:25:27 PDT
https://trac.webkit.org/r171560