Summary: | REGRESSION (r171376): Sometimes we detect less than the whole phone number | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | WebCore Misc. | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, enrica, rniwa, sam | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2014-07-23 16:50:07 PDT
Created attachment 235391 [details]
patch
Created attachment 235393 [details]
patch
This sounds great, and is probably what we should've done in the first place. Comment on attachment 235393 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=235393&action=review > Source/WebCore/editing/Editor.cpp:3438 > + Really necessary? Paragraphing seemed okay before. (In reply to comment #4) > (From update of attachment 235393 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235393&action=review > > > Source/WebCore/editing/Editor.cpp:3438 > > + > > Really necessary? Paragraphing seemed okay before. Not necessary! Just left over from some debugging logging that I failed to remove entirely. Thanks for your review! (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 235393 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=235393&action=review > > > > > Source/WebCore/editing/Editor.cpp:3438 > > > + > > > > Really necessary? Paragraphing seemed okay before. > > Not necessary! Just left over from some debugging logging that I failed to remove entirely. Though somehow I managed to land it anyway :| > Thanks for your review! |