Bug 135216

Summary:

Add a pseudo target to create sandbox override roots

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Oliver Hunt

Reported 2014-07-23 14:52:59 PDT

Add a pseudo target to create sandbox override roots

Attachments
Patch (5.85 KB, patch) 2014-07-23 14:59 PDT, Oliver Hunt	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2014-07-23 14:59:07 PDT

Created attachment 235382 [details] Patch

Alexey Proskuryakov

Comment 2 2014-07-23 15:01:55 PDT

Comment on attachment 235382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235382&action=review > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:10029 > + PRODUCT_NAME = "WebKit2SandboxProfiles copy"; :-/ > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:10036 > + PRODUCT_NAME = "WebKit2SandboxProfiles copy"; :-/ > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:10043 > + PRODUCT_NAME = "WebKit2SandboxProfiles copy"; :-/

Oliver Hunt

Comment 3 2014-07-23 15:04:21 PDT

Committed r171493: <http://trac.webkit.org/changeset/171493>

mitz

Comment 4 2014-07-23 17:52:10 PDT

(In reply to comment #0) > Add a pseudo target to create sandbox override roots What makes this new target a “pseudo target”? Why can’t this be accomplished by a build setting to the existing target (similarly to how there are no separate targets for staged frameworks)?

Note You need to log in before you can comment on or make changes to this bug.