Bug 135204

Summary:

[New Multicolumn] Paginated RenderViews with RL or LR progression don't handle percentages correctly

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none

Dave Hyatt

Reported 2014-07-23 11:52:40 PDT

Paginated RenderViews with RL or LR progression don't handle percentages correctly. I just needed to add back code that was in place for the old columns.

Attachments
Patch (99.77 KB, patch) 2014-07-23 11:56 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (93.96 KB, patch) 2014-07-23 11:58 PDT, Dave Hyatt	simon.fraser: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (652.21 KB, application/zip) 2014-07-23 13:25 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (649.36 KB, application/zip) 2014-07-23 14:21 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (645.48 KB, application/zip) 2014-07-23 15:01 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2014-07-23 11:56:23 PDT

Created attachment 235363 [details] Patch

Dave Hyatt

Comment 2 2014-07-23 11:58:21 PDT

Created attachment 235364 [details] Patch

Simon Fraser (smfr)

Comment 3 2014-07-23 12:01:20 PDT

Comment on attachment 235364 [details] Patch Can't it be a ref test?

Build Bot

Comment 4 2014-07-23 13:25:15 PDT

Comment on attachment 235364 [details] Patch Attachment 235364 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5226907327004672 New failing tests: fast/multicol/pagination/RightToLeft-max-width.html

Build Bot

Comment 5 2014-07-23 13:25:18 PDT

Created attachment 235370 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2014-07-23 14:21:13 PDT

Comment on attachment 235364 [details] Patch Attachment 235364 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4903620843667456 New failing tests: fast/multicol/pagination/RightToLeft-max-width.html

Build Bot

Comment 7 2014-07-23 14:21:17 PDT

Created attachment 235377 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 8 2014-07-23 15:01:14 PDT

Comment on attachment 235364 [details] Patch Attachment 235364 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6587505721737216 New failing tests: fast/multicol/pagination/RightToLeft-max-width.html

Build Bot

Comment 9 2014-07-23 15:01:17 PDT

Created attachment 235383 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Dave Hyatt

Comment 10 2014-07-25 12:40:07 PDT

Fixed in r171609.

Note You need to log in before you can comment on or make changes to this bug.