Bug 135187

Summary: [iOS][WK2] r171124 is incorrect when the virtual keyboard is up
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Benjamin Poulain
Reported 2014-07-22 20:11:38 PDT
[iOS][WK2] r171124 is incorrect when the virtual keyboard is up
Attachments
Patch (6.83 KB, patch)
2014-07-22 20:37 PDT, Benjamin Poulain 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-07-22 20:37:24 PDT
Created attachment 235339 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-07-22 22:33:33 PDT
Comment on attachment 235339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235339&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:803 > + CGFloat maxHorizontalOffset = contentSize.width + contentInsets.right - scrollViewSize.width; > + if (contentOffset.x > maxHorizontalOffset) > + contentOffset.x = maxHorizontalOffset; > + CGFloat maxVerticalOffset = contentSize.height + contentInsets.bottom - scrollViewSize.height; > + if (contentOffset.y > maxVerticalOffset) > + contentOffset.y = maxVerticalOffset; > + if (contentOffset.x < -contentInsets.left) > + contentOffset.x = -contentInsets.left; > + if (contentOffset.y < -contentInsets.top) > + contentOffset.y = -contentInsets.top; > + return contentOffset; std::min()/std::max()?
Benjamin Poulain
Comment 3 2014-07-23 22:02:42 PDT
Committed r171507: <http://trac.webkit.org/changeset/171507>
Note You need to log in before you can comment on or make changes to this bug.