Bug 135187

Summary:

[iOS][WK2] r171124 is incorrect when the virtual keyboard is up

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Benjamin Poulain 2014-07-22 20:11:38 PDT

[iOS][WK2] r171124 is incorrect when the virtual keyboard is up

Comment 1 Benjamin Poulain 2014-07-22 20:37:24 PDT

Created attachment 235339 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-07-22 22:33:33 PDT

Comment on attachment 235339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235339&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:803
> +    CGFloat maxHorizontalOffset = contentSize.width + contentInsets.right - scrollViewSize.width;
> +    if (contentOffset.x > maxHorizontalOffset)
> +        contentOffset.x = maxHorizontalOffset;
> +    CGFloat maxVerticalOffset = contentSize.height + contentInsets.bottom - scrollViewSize.height;
> +    if (contentOffset.y > maxVerticalOffset)
> +        contentOffset.y = maxVerticalOffset;
> +    if (contentOffset.x < -contentInsets.left)
> +        contentOffset.x = -contentInsets.left;
> +    if (contentOffset.y < -contentInsets.top)
> +        contentOffset.y = -contentInsets.top;
> +    return contentOffset;

std::min()/std::max()?

Comment 3 Benjamin Poulain 2014-07-23 22:02:42 PDT

Committed r171507: <http://trac.webkit.org/changeset/171507>