| Summary: | Ensure we compute the min and max height of replaced elements to 'none' or 0 when appropriate. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||
| Component: | Layout and Rendering | Assignee: | Bem Jones-Bey <bjonesbe> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Bem Jones-Bey
2014-07-22 15:43:46 PDT
Created attachment 235323 [details]
Patch
Comment on attachment 235323 [details]
Patch
r=me
Comment on attachment 235323 [details] Patch Clearing flags on attachment: 235323 Committed r171480: <http://trac.webkit.org/changeset/171480> All reviewed patches have been landed. Closing bug. This needs to be rolled out. It's broken replaced elements in books/columns. So iBooks relies on being able to use max-width/height to clamp image sizes. This change has broken that completely, leaving the images to spill across columns/pages. We'll need to figure something out for iBooks before landing this again. It might be that viewport units are what they should switch to instead of 100%, but what really surprised me is that even in quirks mode, the pagination stuff stayed broken. See https://bugs.webkit.org/show_bug.cgi?id=135204 for a test case that shows what books do. Looking at this code: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#3588 Git Blame seems to suggest this commit: https://commits.webkit.org/189967@main Do we need to keep it open? @Alan? |