Bug 135181

Summary: Ensure we compute the min and max height of replaced elements to 'none' or 0 when appropriate.
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: Layout and RenderingAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Bem Jones-Bey
Reported 2014-07-22 15:43:46 PDT
Ensure we compute the min and max height of replaced elements to 'none' or 0 when appropriate.
Attachments
Patch (12.76 KB, patch)
2014-07-22 16:03 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2014-07-22 16:03:17 PDT
Created attachment 235323 [details] Patch
Dave Hyatt
Comment 2 2014-07-23 10:33:53 PDT
Comment on attachment 235323 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-07-23 10:56:43 PDT
Comment on attachment 235323 [details] Patch Clearing flags on attachment: 235323 Committed r171480: <http://trac.webkit.org/changeset/171480>
WebKit Commit Bot
Comment 4 2014-07-23 10:56:45 PDT
All reviewed patches have been landed. Closing bug.
Dave Hyatt
Comment 5 2014-07-25 12:02:08 PDT
This needs to be rolled out. It's broken replaced elements in books/columns.
Dave Hyatt
Comment 6 2014-07-25 12:12:13 PDT
So iBooks relies on being able to use max-width/height to clamp image sizes. This change has broken that completely, leaving the images to spill across columns/pages. We'll need to figure something out for iBooks before landing this again. It might be that viewport units are what they should switch to instead of 100%, but what really surprised me is that even in quirks mode, the pagination stuff stayed broken.
Dave Hyatt
Comment 7 2014-07-25 12:40:48 PDT
See https://bugs.webkit.org/show_bug.cgi?id=135204 for a test case that shows what books do.
Ahmad Saleem
Comment 8 2023-07-02 16:17:07 PDT
Looking at this code: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#3588 Git Blame seems to suggest this commit: https://commits.webkit.org/189967@main Do we need to keep it open? @Alan?
Radar WebKit Bug Importer
Comment 9 2023-07-03 06:42:17 PDT
<rdar://problem/111684345>
Note You need to log in before you can comment on or make changes to this bug.