Summary: | Remove CSS_EXCLUSIONS compile flag and leftover code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||||
Component: | Tools / Tests | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, bunhere, commit-queue, gyuyoung.kim, rakuco, rniwa, sergio, zoltan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Bem Jones-Bey
2014-07-22 14:13:59 PDT
Created attachment 235314 [details]
Patch
Hey Bem, Can you remove the macros from WebKitLibraries/win/tools/vsprops/FeatureDefines.props and WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props as well? Created attachment 235325 [details]
Patch
Removed from missed files as well
Comment on attachment 235325 [details] Patch Attachment 235325 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6401993736192000 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 235335 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 235325 [details]
Patch
The failing test is unrelated, some of the bots are stuck, but the patch is cool!
Comment on attachment 235325 [details]
Patch
The bots are full of lies, there is no way this patch could cause that test to fail. So I'm pushing it though anyways.
Comment on attachment 235325 [details] Patch Clearing flags on attachment: 235325 Committed r171479: <http://trac.webkit.org/changeset/171479> All reviewed patches have been landed. Closing bug. |