Bug 135175

Summary: Remove CSS_EXCLUSIONS compile flag and leftover code
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: Tools / TestsAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, commit-queue, gyuyoung.kim, rakuco, rniwa, sergio, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 none

Bem Jones-Bey
Reported 2014-07-22 14:13:59 PDT
Remove CSS_EXCLUSIONS compile flag and leftover code
Attachments
Patch (37.64 KB, patch)
2014-07-22 14:19 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch (49.57 KB, patch)
2014-07-22 16:30 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (553.50 KB, application/zip)
2014-07-22 18:56 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2014-07-22 14:19:01 PDT
Created attachment 235314 [details] Patch
Zoltan Horvath
Comment 2 2014-07-22 16:18:52 PDT
Hey Bem, Can you remove the macros from WebKitLibraries/win/tools/vsprops/FeatureDefines.props and WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props as well?
Bem Jones-Bey
Comment 3 2014-07-22 16:30:23 PDT
Created attachment 235325 [details] Patch Removed from missed files as well
Build Bot
Comment 4 2014-07-22 18:56:29 PDT
Comment on attachment 235325 [details] Patch Attachment 235325 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6401993736192000 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 5 2014-07-22 18:56:33 PDT
Created attachment 235335 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Zoltan Horvath
Comment 6 2014-07-22 21:50:58 PDT
Comment on attachment 235325 [details] Patch The failing test is unrelated, some of the bots are stuck, but the patch is cool!
Bem Jones-Bey
Comment 7 2014-07-23 10:02:38 PDT
Comment on attachment 235325 [details] Patch The bots are full of lies, there is no way this patch could cause that test to fail. So I'm pushing it though anyways.
WebKit Commit Bot
Comment 8 2014-07-23 10:35:51 PDT
Comment on attachment 235325 [details] Patch Clearing flags on attachment: 235325 Committed r171479: <http://trac.webkit.org/changeset/171479>
WebKit Commit Bot
Comment 9 2014-07-23 10:35:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.