Bug 135162

Summary: Merge FixedIntegerConversion and FixedFloatConversion for CSSPrimitiveValue::convertToLength
Product: WebKit Reporter: Martin Hodovan <mhodovan.u-szeged>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: bfulgham, bjonesbe, buildbot, jchaffraix, kling, macpherson, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
bfulgham: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 none

Martin Hodovan
Reported 2014-07-22 10:17:03 PDT
Merge FixedIntegerConversion and FixedFloatConversion for CSSPrimitiveValue::convertToLength
Attachments
Proposed patch (12.47 KB, patch)
2014-07-22 10:27 PDT, Martin Hodovan 		bfulgham: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (571.05 KB, application/zip)
2014-07-22 16:07 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Martin Hodovan
Comment 1 2014-07-22 10:27:01 PDT
Created attachment 235296 [details] Proposed patch Patch by Timothy Loh, backported from Blink: https://codereview.chromium.org/68203023
Build Bot
Comment 2 2014-07-22 16:07:51 PDT
Comment on attachment 235296 [details] Proposed patch Attachment 235296 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6545296393764864 New failing tests: media/W3C/video/paused/paused_false_during_play.html transforms/cssmatrix-2d-interface.xhtml
Build Bot
Comment 3 2014-07-22 16:07:54 PDT
Created attachment 235324 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Darin Adler
Comment 4 2014-07-23 09:39:45 PDT
Comment on attachment 235296 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=235296&action=review > Source/WebCore/ChangeLog:14 > + differences. The FixedIntegerConversion clamps to about the range of > + LayoutUnits (+-32mil) and doesn't actually convert to an integer. > + FixedFloatConversion simple doesn't clamp. This describes a difference. > Source/WebCore/ChangeLog:23 > + No change in functionality, no new tests. This claims there is no change. Which is it?
Brent Fulgham
Comment 5 2016-03-14 11:32:36 PDT
(In reply to comment #4) > > Source/WebCore/ChangeLog:23 > > + No change in functionality, no new tests. > > This claims there is no change. Which is it? The fact that it introduced test failures indicates there is a change! :-)
Brent Fulgham
Comment 6 2016-03-14 11:33:30 PDT
Comment on attachment 235296 [details] Proposed patch This change doesn't apply against current sources, and introduces at least one test regression. Please rebaseline the patch against current sources and correct the test failure.
Brent Fulgham
Comment 7 2022-07-13 17:23:34 PDT
This code has been significantly refactored since this patch was proposed. There doesn't seem to be any action we can take here.
Note You need to log in before you can comment on or make changes to this bug.