Summary: | Correct auto-version.pl handling of __VERSION_TEXT__, __BUILD_NUMBER__, and __BUILD_NUMBER_SHORT__ for 4+-tuple versions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dbates, ddkilzer, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brent Fulgham
2014-07-22 09:44:14 PDT
Created attachment 235294 [details]
Patch
Comment on attachment 235294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235294&action=review r=me > WebKitLibraries/win/tools/scripts/auto-version.pl:126 > + $PROPOSED_VERSION =~ s/^\s*(.*)\s*$/$1/; # Get rid of any leading/trailing whitespace > + Please add one test with trailing and leading whitespace. (I didn't see any added to this patch.) > WebKitLibraries/win/tools/scripts/auto-version.pl:127 > # Split out the three components of the dotted version number. We pad Nit: "three components" isn't accurate; maybe just remove the word "three". > WebKitLibraries/win/tools/scripts/auto-version.pl:153 > + $PROPOSED_VERSION = substr $PROPOSED_VERSION, $charactersToRemove; Nit: Kind of weird to omit parens here for substr() when they're used everywhere else. Comment on attachment 235294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235294&action=review >> WebKitLibraries/win/tools/scripts/auto-version.pl:126 >> + > > Please add one test with trailing and leading whitespace. (I didn't see any added to this patch.) Will do. >> WebKitLibraries/win/tools/scripts/auto-version.pl:127 >> # Split out the three components of the dotted version number. We pad > > Nit: "three components" isn't accurate; maybe just remove the word "three". Done. >> WebKitLibraries/win/tools/scripts/auto-version.pl:153 >> + $PROPOSED_VERSION = substr $PROPOSED_VERSION, $charactersToRemove; > > Nit: Kind of weird to omit parens here for substr() when they're used everywhere else. Agreed! Fixed. Committed r171351: <http://trac.webkit.org/changeset/171351> |