Bug 13511

Summary:

REGRESSION: Crash visiting a page

Product:

WebKit

Reporter:

jonathanjohnsson

Component:

New Bugs

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Regression

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.markschenk.com/cssexp/publication/article.xml

Attachments:

Description	Flags
Patch to fix the problem	hyatt: review+

jonathanjohnsson

Reported 2007-04-26 14:06:48 PDT

WebKit crashes on http://www.markschenk.com/cssexp/publication/article.xml, released Safari doesn't. I built it yesterday, don't remember what revision it was.

Attachments
Patch to fix the problem (13.10 KB, patch) 2007-04-26 15:56 PDT, Dave Hyatt	hyatt: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2007-04-26 14:12:22 PDT

Revision 21121 0 com.apple.WebCore 0x0147c44d WebCore::StringImpl::length() const + 9 (StringImpl.h:72) 1 com.apple.WebCore 0x014fb7b8 WebCore::RenderText::textLength() const + 28 (RenderText.h:68) 2 com.apple.WebCore 0x0117e8c3 WebCore::RenderText::trimmedPrefWidths(int, int&, bool&, int&, bool&, bool&, bool&, int&, int&, int&, int&, bool&) + 59 (RenderText.cpp:431) 3 com.apple.WebCore 0x0112d684 WebCore::RenderBlock::calcInlinePrefWidths() + 1488 (RenderBlock.cpp:3595) 4 com.apple.WebCore 0x0112daa3 WebCore::RenderBlock::calcPrefWidths() + 353 (RenderBlock.cpp:3254) 5 com.apple.WebCore 0x011397ab WebCore::RenderBox::minPrefWidth() const + 41 (RenderBox.cpp:176) 6 com.apple.WebCore 0x011901e8 WebCore::RenderTable::calcPrefWidths() + 200 (RenderTable.cpp:540) 7 com.apple.WebCore 0x011397dd WebCore::RenderBox::maxPrefWidth() const + 41 (RenderBox.cpp:184) 8 com.apple.WebCore 0x0118dacf WebCore::RenderTable::calcWidth() + 549 (RenderTable.cpp:253) 9 com.apple.WebCore 0x0119045f WebCore::RenderTable::layout() + 565 (RenderTable.cpp:300) 10 com.apple.WebCore 0x014fb685 WebCore::RenderObject::layoutIfNeeded() + 41 (RenderObject.h:474) 11 com.apple.WebCore 0x01133e05 WebCore::RenderBlock::layoutBlockChildren(bool) + 1461 (RenderBlock.cpp:1182) 12 com.apple.WebCore 0x01138a13 WebCore::RenderBlock::layoutBlock(bool) + 1323 (RenderBlock.cpp:566) 13 com.apple.WebCore 0x01129c22 WebCore::RenderBlock::layout() + 54 (RenderBlock.cpp:473) 14 com.apple.WebCore 0x014fb685 WebCore::RenderObject::layoutIfNeeded() + 41 (RenderObject.h:474) 15 com.apple.WebCore 0x01133e05 WebCore::RenderBlock::layoutBlockChildren(bool) + 1461 (RenderBlock.cpp:1182) 16 com.apple.WebCore 0x01138a13 WebCore::RenderBlock::layoutBlock(bool) + 1323 (RenderBlock.cpp:566) 17 com.apple.WebCore 0x01129c22 WebCore::RenderBlock::layout() + 54 (RenderBlock.cpp:473) 18 com.apple.WebCore 0x014fb685 WebCore::RenderObject::layoutIfNeeded() + 41 (RenderObject.h:474) 19 com.apple.WebCore 0x01133e05 WebCore::RenderBlock::layoutBlockChildren(bool) + 1461 (RenderBlock.cpp:1182) 20 com.apple.WebCore 0x01138a13 WebCore::RenderBlock::layoutBlock(bool) + 1323 (RenderBlock.cpp:566) 21 com.apple.WebCore 0x01129c22 WebCore::RenderBlock::layout() + 54 (RenderBlock.cpp:473) 22 com.apple.WebCore 0x014fb685 WebCore::RenderObject::layoutIfNeeded() + 41 (RenderObject.h:474) 23 com.apple.WebCore 0x01133e05 WebCore::RenderBlock::layoutBlockChildren(bool) + 1461 (RenderBlock.cpp:1182) 24 com.apple.WebCore 0x01138a13 WebCore::RenderBlock::layoutBlock(bool) + 1323 (RenderBlock.cpp:566) 25 com.apple.WebCore 0x01129c22 WebCore::RenderBlock::layout() + 54 (RenderBlock.cpp:473) 26 com.apple.WebCore 0x01143662 WebCore::RenderView::layout() + 208 (RenderView.cpp:106) 27 com.apple.WebCore 0x010c3ae1 WebCore::FrameView::layout(bool) + 1763 (FrameView.cpp:413) 28 com.apple.WebCore 0x010c3d69 WebCore::FrameView::layoutTimerFired(WebCore::Timer<WebCore::FrameView>*) + 25 (FrameView.cpp:621) 29 com.apple.WebCore 0x014cfed3 WebCore::Timer<WebCore::FrameView>::fired() + 91 (Timer.h:96) 30 com.apple.WebCore 0x011e86a6 WebCore::TimerBase::fireTimers(double, WTF::Vector<WebCore::TimerBase*, (unsigned long)0> const&) + 196 (Timer.cpp:322) 31 com.apple.WebCore 0x011e8743 WebCore::TimerBase::sharedTimerFired() + 109 (Timer.cpp:355) 32 com.apple.WebCore 0x011e7dfa WebCore::timerFired(__CFRunLoopTimer*, void*) + 22 (SharedTimerMac.cpp:47)

Dave Hyatt

Comment 2 2007-04-26 14:20:23 PDT

Something going wrong with table caption min pref width.

Dave Hyatt

Comment 3 2007-04-26 15:56:11 PDT

Created attachment 14214 [details] Patch to fix the problem

Dave Hyatt

Comment 4 2007-04-26 17:31:21 PDT

I have a layout test for this that uses a counter inside a table caption.

Dave Hyatt

Comment 5 2007-04-26 17:40:41 PDT

Comment on attachment 14214 [details] Patch to fix the problem r=me

Dave Hyatt

Comment 6 2007-04-26 17:40:58 PDT

r=aroben hahah oops.

Dave Hyatt

Comment 7 2007-04-26 17:50:40 PDT

Fixed.

Note You need to log in before you can comment on or make changes to this bug.