Summary: | Crashes seen in wheel event handling | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
Component: | UI Events | Assignee: | Darin Adler <darin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, bfulgham, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Darin Adler
2014-07-20 10:39:38 PDT
Created attachment 235186 [details]
Patch
Created attachment 235187 [details]
Patch
Comment on attachment 235187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235187&action=review > Source/WebCore/page/EventHandler.cpp:2578 > + // Instead, the handlers should know convert vertical scrolls appropriately. Oops, typo here. Should be "how to convert". Comment on attachment 235187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235187&action=review > Source/WebCore/page/mac/EventHandlerMac.mm:850 > + // FIXME: I don't understand the lifetime guarantee for this data member. I think this is a great question, but it feels little oddly phrased as a comment in the context of other WebKit comments. Maybe it's fine, but I think you could also just have: FIXME: What prevents us from deleting this scrollable container while still holding a pointer to it? Committed r171283: <http://trac.webkit.org/changeset/171283> |