Bug 135083

Summary:

Perf dashboard shouldn't show the full git hash

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, dfarler, kling, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	benjamin: review+

Description Ryosuke Niwa 2014-07-18 21:45:58 PDT

Right now the perf dashboard shows the entire git hash in the popups and in the panes.
We should only show the first 8 characters.

Comment 1 Ryosuke Niwa 2014-07-18 21:47:55 PDT

Created attachment 235167 [details]
Fixes the bug

Comment 2 Benjamin Poulain 2014-07-18 21:53:52 PDT

Comment on attachment 235167 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=235167&action=review

> Websites/perf.webkit.org/public/js/helper-classes.js:101
> +                formattedCurrentHash = currentRevision.substring(0, 8);

formattedCurrentHash = currentRevision[:8] ?

> Websites/perf.webkit.org/public/js/helper-classes.js:103
> +                    labelForThisRepository = previousRevision.substring(0, 8) + '..' + formattedCurrentHash;

ditto for substring

Comment 3 Benjamin Poulain 2014-07-18 21:56:59 PDT

(In reply to comment #2)
> (From update of attachment 235167 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235167&action=review
> 
> > Websites/perf.webkit.org/public/js/helper-classes.js:101
> > +                formattedCurrentHash = currentRevision.substring(0, 8);
> 
> formattedCurrentHash = currentRevision[:8] ?
> 
> > Websites/perf.webkit.org/public/js/helper-classes.js:103
> > +                    labelForThisRepository = previousRevision.substring(0, 8) + '..' + formattedCurrentHash;
> 
> ditto for substring

Never mind :)

Comment 4 Ryosuke Niwa 2014-07-18 21:59:50 PDT

Committed r171258: <http://trac.webkit.org/changeset/171258>