Bug 135083 – Perf dashboard shouldn't show the full git hash

• Component: Perf Dashboard
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Right now the perf dashboard shows the entire git hash in the popups and in the panes.
We should only show the first 8 characters.

[Ryosuke Niwa]

Created attachment 235167 [details]
Fixes the bug

[Benjamin Poulain]

Comment on attachment 235167 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=235167&action=review

> Websites/perf.webkit.org/public/js/helper-classes.js:101
> +                formattedCurrentHash = currentRevision.substring(0, 8);

formattedCurrentHash = currentRevision[:8] ?

> Websites/perf.webkit.org/public/js/helper-classes.js:103
> +                    labelForThisRepository = previousRevision.substring(0, 8) + '..' + formattedCurrentHash;

ditto for substring

[Benjamin Poulain]

(In reply to comment #2)
> (From update of attachment 235167 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235167&action=review
> 
> > Websites/perf.webkit.org/public/js/helper-classes.js:101
> > +                formattedCurrentHash = currentRevision.substring(0, 8);
> 
> formattedCurrentHash = currentRevision[:8] ?
> 
> > Websites/perf.webkit.org/public/js/helper-classes.js:103
> > +                    labelForThisRepository = previousRevision.substring(0, 8) + '..' + formattedCurrentHash;
> 
> ditto for substring

Never mind :)

[Ryosuke Niwa]

Committed r171258: <http://trac.webkit.org/changeset/171258>