Summary: | Take navigation snapshots whenever the current back-forward item is going to change | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, benjamin, commit-queue, japhet, mitz, rniwa, sam, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2014-07-18 11:41:07 PDT
Created attachment 235134 [details]
patch
Comment on attachment 235134 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=235134&action=review > Source/WebCore/loader/HistoryController.cpp:882 > + m_frame.loader().client().willChangeCurrentHistoryItem(); Do we need to call this if we end up changing just the provisional item? Comment on attachment 235134 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=235134&action=review >> Source/WebCore/loader/HistoryController.cpp:882 >> + m_frame.loader().client().willChangeCurrentHistoryItem(); > > Do we need to call this if we end up changing just the provisional item? No, good point. Thanks! Looks like this caused a PLT regression on all platforms. |