Bug 135037

Summary:

iOS WK2: visibleBounds should return the unobscured content rect

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebKit2

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED WONTFIX

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Enrica Casucci 2014-07-17 18:25:20 PDT

This is needed to properly clip the position of the menu bar.

<rdar://problem/15980307>

Comment 1 Enrica Casucci 2014-07-17 18:28:09 PDT

Created attachment 235106 [details]
Patch

Comment 2 Enrica Casucci 2014-07-17 18:58:20 PDT

After discussing this with Ben, we agreed that this is not the right thing to do here.

Comment 3 Enrica Casucci 2014-07-17 18:58:54 PDT

After discussing this with Ben, we agreed that this is not the right thing to do here.

Comment 4 Benjamin Poulain 2014-07-17 19:08:35 PDT

Comment on attachment 235106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235106&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:365
> +- (CGRect)visibleBounds
> +{
> +    return [self unobscuredContentRect];
> +}

Can you add a comment explaining how "visibleBounds" is used by UIKit?
I think the name is quite bad, but we don't have much freedom here since this is part of the UIView's interface.