Bug 135030

Summary: Simplify WebOriginDataManager(Proxy) and rename to UIProcessOriginDataManager and ChildProcessOriginDataManager
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED WONTFIX    
Severity: Normal CC: commit-queue, mkwst
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 - Rename, remove some cruft, add callbacks for all 3 API methods. none

Brady Eidson
Reported 2014-07-17 15:43:08 PDT
Simplify WebOriginDataManager(Proxy) and rename to UIProcessOriginDataManager and ChildProcessOriginDataManager What is today called a "WebOriginDataManagerProxy" that exists in a WebProcess will actually exist in any ChildProcess type (Web, Networking, Database). The WebOriginDataManager is still UIProcess-only. So the renaming is pretty clear. At the same time, I'll be removing cruft (like the change notification client stuff) that we don't have a need for right now. It can always be added back later.
Attachments
Patch v1 - Rename, remove some cruft, add callbacks for all 3 API methods. (85.77 KB, patch)
2014-07-17 15:49 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-07-17 15:49:06 PDT
Created attachment 235097 [details] Patch v1 - Rename, remove some cruft, add callbacks for all 3 API methods.
WebKit Commit Bot
Comment 2 2014-07-17 15:52:06 PDT
Attachment 235097 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/C/WKOriginDataManager.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/C/WKContext.cpp:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/UIProcessOriginDataManager.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/UIProcessOriginDataManager.cpp:83: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/UIProcessOriginDataManager.cpp:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/UIProcessOriginDataManager.cpp:132: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Shared/ChildProcessOriginDataManager.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/UIProcessOriginDataManager.h:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/UIProcessOriginDataManager.h:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/UIProcessOriginDataManager.h:58: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 10 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2014-07-17 15:55:08 PDT
Comment on attachment 235097 [details] Patch v1 - Rename, remove some cruft, add callbacks for all 3 API methods. Not going to do this right now.
Note You need to log in before you can comment on or make changes to this bug.