Summary: | Sometimes purgeable (or empty!) tiles are shown on screen when resuming the app | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, benjamin, mitz, sam, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2014-07-17 12:05:14 PDT
Created attachment 235082 [details]
patch
Comment on attachment 235082 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=235082&action=review > Source/WebKit2/UIProcess/DrawingAreaProxy.h:91 > + virtual void hideContentUntilNextUpdate() { ASSERT_NOT_REACHED(); } Doesn’t seem right. If WKContentView knows that its drawing area is a RemoteLayerTreeDrawingAreaProxy, then it could be written to do a safe downcast and this function could be in that class instead of here in this base class. If WKContentView doesn’t know that its drawing area is a RemoteLayerTreeDrawingAreaProxy, then we can’t ASSERT_NOT_REACHED. |