Bug 135006 – SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig

• Component: Tools / Tests
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Building all targets with the same SECTORDER_FLAGS makes no sense because *.order files are specific to a target.

We should consider moving the SECTORDER_FLAGS variables to the target xcconfig in each project that will use them.

[David Kilzer (:ddkilzer)]

Created attachment 235095 [details]
Patch v1

[WebKit Commit Bot]

Comment on attachment 235095 [details]
Patch v1

Clearing flags on attachment: 235095

Committed r171212: <http://trac.webkit.org/changeset/171212>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Philip Rogers]

No review?

I think this breaks the external build:
=== BUILD TARGET llvmForJSC OF PROJECT JavaScriptCore WITH CONFIGURATION Debug ===

Check dependencies
Base.xcconfig line 23: Unable to find included file "iOS.xcconfig"
Base.xcconfig line 24: Unable to find included file "../../../../Internal/Configurations/UseInternalSDK.xcconfig"
The file “LLVMForJSC.xcconfig” couldn’t be opened because there is no such file. (/Users/pdr/Desktop/WebKit/Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig)
Build setting PRODUCT_NAME undefined

** BUILD FAILED **

(In reply to comment #4)
> No review?

<https://bugs.webkit.org/show_activity.cgi?id=135006> shows that Darin Adler has reviewed the patch.

> 
> I think this breaks the external build:
> === BUILD TARGET llvmForJSC OF PROJECT JavaScriptCore WITH CONFIGURATION Debug ===
> 
> Check dependencies
> Base.xcconfig line 23: Unable to find included file "iOS.xcconfig"
> Base.xcconfig line 24: Unable to find included file "../../../../Internal/Configurations/UseInternalSDK.xcconfig"
> The file “LLVMForJSC.xcconfig” couldn’t be opened because there is no such file. (/Users/pdr/Desktop/WebKit/Source/JavaScriptCore/Configurations/LLVMForJSC.xcconfig)
> Build setting PRODUCT_NAME undefined
> 
> ** BUILD FAILED **

The above failure doesn’t appear to be related to the patch. It’s failing because it can’t find LLVMForJSC.xcconfig, but that file wasn’t touched.

[Darin Adler]

(In reply to comment #4)
> No review?

I reviewed this.

> I think this breaks the external build:

I don’t think so. As Dan says, that problem you are seeing is something different.

[Philip Rogers]

(In reply to comment #6)
> (In reply to comment #4)
> > No review?
> 
> I reviewed this.
> 
> > I think this breaks the external build:
> 
> I don’t think so. As Dan says, that problem you are seeing is something different.

I apologize, this patch was fine. I blame jetlag :(

I clicked "formatted diff" instead of the patch that landed, and had a local change which caused the failure.