Bug 134993

Summary: [iOS] Update order file paths for WebKit and WebKit2
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, dbates, dfarler, joepeck, mitz, mrowe, psolanki, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2014-07-16 16:30:15 PDT
Need to update the order files for WebKit and WebKit2 for iOS.
Attachments
Patch v1 (2.90 KB, patch)
2014-07-16 17:08 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2014-07-16 16:30:32 PDT
<rdar://problem/17557776>
David Kilzer (:ddkilzer)
Comment 2 2014-07-16 17:08:40 PDT
Created attachment 235036 [details] Patch v1
WebKit Commit Bot
Comment 3 2014-07-16 18:38:27 PDT
Comment on attachment 235036 [details] Patch v1 Clearing flags on attachment: 235036 Committed r171164: <http://trac.webkit.org/changeset/171164>
WebKit Commit Bot
Comment 4 2014-07-16 18:38:30 PDT
All reviewed patches have been landed. Closing bug.
mitz
Comment 5 2014-07-16 18:40:38 PDT
Not new to this patch, but I’d like to understand why this is specified in Base.xcconfig rather than in the configuration for the target that builds the framework.
David Kilzer (:ddkilzer)
Comment 6 2014-07-16 20:18:56 PDT
(In reply to comment #5) > Not new to this patch, but I’d like to understand why this is specified in Base.xcconfig rather than in the configuration for the target that builds the framework. The only reason I can think of doing it in the Base.xcconfig is that it's easy to override (to no order file) for Debug/Release builds. However, I don't know of any downsides to specifying an order file in Debug/Release, unless it makes link times significantly longer. I filed Bug 135006.
Note You need to log in before you can comment on or make changes to this bug.