Bug 134985

Summary: Enable legacy fullscreen API in media controls
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, calvaris, commit-queue, eric.carlson, glenn, philipj, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
none
Patch for landing none

Jer Noble
Reported 2014-07-16 10:52:20 PDT
Enable legacy fullscreen API in media controls
Attachments
Patch (3.54 KB, patch)
2014-07-16 13:43 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (599.60 KB, application/zip)
2014-07-16 14:38 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (586.88 KB, application/zip)
2014-07-16 15:08 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (741.92 KB, application/zip)
2014-07-16 15:18 PDT, Build Bot 		no flags
Details
Patch for landing (8.60 KB, patch)
2014-07-16 17:16 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-07-16 13:43:52 PDT
Created attachment 235019 [details] Patch
Build Bot
Comment 2 2014-07-16 14:38:31 PDT
Comment on attachment 235019 [details] Patch Attachment 235019 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5559840743096320 New failing tests: fast/layers/video-layer.html fast/hidpi/video-controls-in-hidpi.html media/media-controls-clone.html webarchive/loading/video-in-webarchive.html
Build Bot
Comment 3 2014-07-16 14:38:34 PDT
Created attachment 235023 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2014-07-16 15:08:19 PDT
Comment on attachment 235019 [details] Patch Attachment 235019 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5373753231933440 New failing tests: fast/layers/video-layer.html fast/hidpi/video-controls-in-hidpi.html media/media-controls-clone.html webarchive/loading/video-in-webarchive.html
Build Bot
Comment 5 2014-07-16 15:08:23 PDT
Created attachment 235025 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 6 2014-07-16 15:18:37 PDT
Comment on attachment 235019 [details] Patch Attachment 235019 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6600361531932672 New failing tests: fast/layers/video-layer.html fast/hidpi/video-controls-in-hidpi.html media/media-controls-clone.html webarchive/loading/video-in-webarchive.html
Build Bot
Comment 7 2014-07-16 15:18:41 PDT
Created attachment 235027 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Jer Noble
Comment 8 2014-07-16 17:16:16 PDT
Created attachment 235037 [details] Patch for landing
WebKit Commit Bot
Comment 9 2014-07-17 09:27:55 PDT
Comment on attachment 235037 [details] Patch for landing Clearing flags on attachment: 235037 Committed r171184: <http://trac.webkit.org/changeset/171184>
Jer Noble
Comment 10 2014-07-17 10:19:45 PDT
<rdar://problem/17172448>
Note You need to log in before you can comment on or make changes to this bug.