Bug 134985

Summary: Enable legacy fullscreen API in media controls
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, calvaris, commit-queue, eric.carlson, glenn, philipj, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
none
Patch for landing none

Description Jer Noble 2014-07-16 10:52:20 PDT
Enable legacy fullscreen API in media controls
Comment 1 Jer Noble 2014-07-16 13:43:52 PDT
Created attachment 235019 [details]
Patch
Comment 2 Build Bot 2014-07-16 14:38:31 PDT
Comment on attachment 235019 [details]
Patch

Attachment 235019 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5559840743096320

New failing tests:
fast/layers/video-layer.html
fast/hidpi/video-controls-in-hidpi.html
media/media-controls-clone.html
webarchive/loading/video-in-webarchive.html
Comment 3 Build Bot 2014-07-16 14:38:34 PDT
Created attachment 235023 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-07-16 15:08:19 PDT
Comment on attachment 235019 [details]
Patch

Attachment 235019 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5373753231933440

New failing tests:
fast/layers/video-layer.html
fast/hidpi/video-controls-in-hidpi.html
media/media-controls-clone.html
webarchive/loading/video-in-webarchive.html
Comment 5 Build Bot 2014-07-16 15:08:23 PDT
Created attachment 235025 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-07-16 15:18:37 PDT
Comment on attachment 235019 [details]
Patch

Attachment 235019 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6600361531932672

New failing tests:
fast/layers/video-layer.html
fast/hidpi/video-controls-in-hidpi.html
media/media-controls-clone.html
webarchive/loading/video-in-webarchive.html
Comment 7 Build Bot 2014-07-16 15:18:41 PDT
Created attachment 235027 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Jer Noble 2014-07-16 17:16:16 PDT
Created attachment 235037 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2014-07-17 09:27:55 PDT
Comment on attachment 235037 [details]
Patch for landing

Clearing flags on attachment: 235037

Committed r171184: <http://trac.webkit.org/changeset/171184>
Comment 10 Jer Noble 2014-07-17 10:19:45 PDT
<rdar://problem/17172448>