Bug 13498

Summary:

Remove currently non working CMake buildsystem

Product:

WebKit

Reporter:

Holger Freyther <zecke>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Remove CMakeLists and invocations	mjs: review+
Remove the last trace of CMake	mrowe: review+

Holger Freyther

Reported 2007-04-26 06:35:16 PDT

The CMake buildsystem was introduced for the Qt/KDE port of WebKit. This port switched over to use qmake and the cmake buildsystem is currently not used by any other port. I propose to remove it.

Attachments
Remove CMakeLists and invocations (71.45 KB, patch) 2007-04-26 06:36 PDT, Holger Freyther	mjs: review+	Details Formatted Diff Diff
Remove the last trace of CMake (1.66 KB, patch) 2007-05-01 07:29 PDT, Holger Freyther	mrowe: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Holger Freyther

Comment 1 2007-04-26 06:36:21 PDT

Created attachment 14199 [details] Remove CMakeLists and invocations

Holger Freyther

Comment 2 2007-04-26 06:46:40 PDT

Comment on attachment 14199 [details] Remove CMakeLists and invocations I forgot to set the review flag. It is now set.

Maciej Stachowiak

Comment 3 2007-04-26 22:38:22 PDT

Comment on attachment 14199 [details] Remove CMakeLists and invocations Sounds ok to me.

Mark Rowe (bdash)

Comment 4 2007-04-27 00:58:17 PDT

Landed in r21138. Thanks Holger!

Holger Freyther

Comment 5 2007-05-01 07:29:15 PDT

Created attachment 14294 [details] Remove the last trace of CMake I missed a (unreachable) call to CMake in build-webkit. This patch removes this call. The isQtWithQMake() method became irrelevant and was removed.

Holger Freyther

Comment 6 2007-05-01 07:30:31 PDT

Sorry for the inconvience, I have missed one spot in the CMake removal and this patch makes it up.

Mark Rowe (bdash)

Comment 7 2007-05-02 02:42:40 PDT

Landed in r21220.

Note You need to log in before you can comment on or make changes to this bug.