| Summary: | Change style check path with EFL WK2's path in checker_unittest.py | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Component: | Tools / Tests | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, glenn, gyuyoung.kim | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 234985 [details]
Patch
Created attachment 234989 [details]
Patch
Comment on attachment 234989 [details]
Patch
rs=me
Comment on attachment 234989 [details] Patch Clearing flags on attachment: 234989 Committed r171142: <http://trac.webkit.org/changeset/171142> All reviewed patches have been landed. Closing bug. |
There is a style check failure in webkitpy tests due to the EFL WK1 path. [859/1424] webkitpy.style.checker_unittest.GlobalVariablesTest.test_path_rules_specifier failed: Traceback (most recent call last): File "/home/gyuyoung/buildbot/efl-linux-wk2-slave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/style/checker_unittest.py", line 225, in test_path_rules_specifier "readability/naming") File "/home/gyuyoung/buildbot/efl-linux-wk2-slave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/style/checker_unittest.py", line 212, in assertNoCheck self.assertFalse(config.should_check(category, path), message) AssertionError: True is not False : Should not check category "readability/naming" for path "Source/WebKit/efl/ewk/ewk_view.h".