Bug 134967

Summary: Change style check path with EFL WK2's path in checker_unittest.py
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: Tools / TestsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2014-07-16 02:32:36 PDT
There is a style check failure in webkitpy tests due to the EFL WK1 path. [859/1424] webkitpy.style.checker_unittest.GlobalVariablesTest.test_path_rules_specifier failed: Traceback (most recent call last): File "/home/gyuyoung/buildbot/efl-linux-wk2-slave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/style/checker_unittest.py", line 225, in test_path_rules_specifier "readability/naming") File "/home/gyuyoung/buildbot/efl-linux-wk2-slave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/style/checker_unittest.py", line 212, in assertNoCheck self.assertFalse(config.should_check(category, path), message) AssertionError: True is not False : Should not check category "readability/naming" for path "Source/WebKit/efl/ewk/ewk_view.h".
Attachments
Patch (1.50 KB, patch)
2014-07-16 02:33 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2014-07-16 03:02 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-07-16 02:33:31 PDT
Created attachment 234985 [details] Patch
Gyuyoung Kim
Comment 2 2014-07-16 03:02:24 PDT
Created attachment 234989 [details] Patch
Csaba Osztrogonác
Comment 3 2014-07-16 03:45:12 PDT
Comment on attachment 234989 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2014-07-16 04:21:12 PDT
Comment on attachment 234989 [details] Patch Clearing flags on attachment: 234989 Committed r171142: <http://trac.webkit.org/changeset/171142>
WebKit Commit Bot
Comment 5 2014-07-16 04:21:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.