Bug 134961

Summary:

[iOS] Fix touches inside accelerated overflow:scroll

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	benjamin: review+

Description Simon Fraser (smfr) 2014-07-15 19:43:43 PDT

[iOS] Fix touches inside accelerated overflow:scroll

Comment 1 Simon Fraser (smfr) 2014-07-15 19:47:55 PDT

Created attachment 234976 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-07-15 19:48:21 PDT

<rdar://problem/16088789>

Comment 3 Benjamin Poulain 2014-07-15 19:55:06 PDT

Comment on attachment 234976 [details]
Patch

I am not a fan, but it is not the right time for changing the architecture.

Comment 4 Simon Fraser (smfr) 2014-07-15 19:58:57 PDT

https://trac.webkit.org/r171132

Comment 5 Darin Adler 2014-07-16 18:02:55 PDT

Comment on attachment 234976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234976&action=review

> Source/WebCore/rendering/RenderBox.cpp:2113
> +static inline bool shouldAppyContainersClipAndOffset(const RenderLayerModelObject* repaintContainer, RenderBox* containerBox)

Typo here: "Appy" instead of "Apply".

Comment 6 Simon Fraser (smfr) 2014-07-16 18:11:08 PDT

Fixed in https://trac.webkit.org/r171163