| Summary: | Adding myself to contributors.json breaks a webkitpy test | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cgarcia, commit-queue, glenn, mrobinson, ossy, pnormand, rniwa, xan.lopez | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 234972 [details]
Patch
Comment on attachment 234972 [details] Patch Clearing flags on attachment: 234972 Committed r171136: <http://trac.webkit.org/changeset/171136> All reviewed patches have been landed. Closing bug. |
I was adding myself to Tools/Scripts/webkitpy/common/config/contributors.json after I was accepted as commiter. However, doing it breaks a test of webkitpy due to usage of the very common spanish surname "lopez" as whois query for the IRC bot tests. $ Tools/Scripts/test-webkitpy Suppressing most webkitpy logging while running unit tests. Skipping tests in the following modules or packages because they are really, really, slow: webkitpy.common.checkout.scm.scm_unittest (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include) Checking imports .../home/clopez/webkit/webkit [809/1424] webkitpy.tool.bot.irc_command_unittest.IRCCommandTest.test_whois failed: Traceback (most recent call last): File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py", line 56, in test_whois whois.execute("tom", ["lopez"], None, None)) AssertionError: 'tom: lopez is "Xan Lopez" <xan.lopez@gmail.com> (:xan) (r). Why do you ask?' != u'tom: I\'m not sure who you mean? "Carlos Alberto Lopez Perez" <clopez@igalia.com> (:clopez) (c) or "Xan Lopez" <xan.lopez@gmail.com> (:xan) (r) could be \'lopez\'.' Ran 1424 tests in 3.843s FAILED (failures=1, errors=0)