Bug 134958 – Adding myself to contributors.json breaks a webkitpy test

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

I was adding myself to Tools/Scripts/webkitpy/common/config/contributors.json after I was accepted as commiter.

However, doing it breaks a test of webkitpy due to usage of the very common spanish surname "lopez" as whois query for the IRC bot tests.

$ Tools/Scripts/test-webkitpy
Suppressing most webkitpy logging while running unit tests.
Skipping tests in the following modules or packages because they are really, really, slow:
    webkitpy.common.checkout.scm.scm_unittest
    (https://bugs.webkit.org/show_bug.cgi?id=31818; use --all to include)

Checking imports .../home/clopez/webkit/webkit
[809/1424] webkitpy.tool.bot.irc_command_unittest.IRCCommandTest.test_whois failed:                                                             
  Traceback (most recent call last):
    File "/home/clopez/webkit/webkit/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py", line 56, in test_whois
      whois.execute("tom", ["lopez"], None, None))
  AssertionError: 'tom: lopez is "Xan Lopez" <[e-mail]> (:xan) (r). Why do you ask?' != u'tom: I\'m not sure who you mean?  "Carlos Alberto Lopez Perez" <[e-mail]> (:clopez) (c) or "Xan Lopez" <[e-mail]> (:xan) (r) could be \'lopez\'.'
  
Ran 1424 tests in 3.843s                                                                              
FAILED (failures=1, errors=0)

[Carlos Alberto Lopez Perez]

Created attachment 234972 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 234972 [details]
Patch

Clearing flags on attachment: 234972

Committed r171136: <http://trac.webkit.org/changeset/171136>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.